Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2739153002: Reload all ContentSuggestions on notification (Closed)

Created:
3 years, 9 months ago by gambard
Modified:
3 years, 9 months ago
Reviewers:
stkhapugin
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reload all ContentSuggestions on notification On backend notification, the UI must remove all displayed suggestions and reload all suggestions. BUG=699124 Review-Url: https://codereview.chromium.org/2739153002 Cr-Commit-Position: refs/heads/master@{#455756} Committed: https://chromium.googlesource.com/chromium/src/+/f06328ee263de78077aee45fde48cefa9d3d4d5d

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -36 lines) Patch
M ios/chrome/browser/content_suggestions/content_suggestions_mediator.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm View 4 chunks +33 lines, -35 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_data_sink.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (7 generated)
gambard
PTAL.
3 years, 9 months ago (2017-03-09 11:58:59 UTC) #2
stkhapugin
lgtm https://codereview.chromium.org/2739153002/diff/1/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm File ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm (right): https://codereview.chromium.org/2739153002/diff/1/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm#newcode160 ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm:160: - (void)reloadAllData { This was just renamed and ...
3 years, 9 months ago (2017-03-09 14:12:05 UTC) #3
gambard
Thanks! https://codereview.chromium.org/2739153002/diff/1/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm File ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm (right): https://codereview.chromium.org/2739153002/diff/1/ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm#newcode160 ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm:160: - (void)reloadAllData { On 2017/03/09 14:12:05, stkhapugin wrote: ...
3 years, 9 months ago (2017-03-09 14:12:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739153002/1
3 years, 9 months ago (2017-03-09 14:13:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/167534) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 9 months ago (2017-03-09 14:15:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2739153002/20001
3 years, 9 months ago (2017-03-09 14:37:54 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 16:10:25 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f06328ee263de78077aee45fde48...

Powered by Google App Engine
This is Rietveld 408576698