Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 2745563002: Add Open in New Tab method for Reading List Delegate (Closed)

Created:
3 years, 9 months ago by gambard
Modified:
3 years, 9 months ago
Reviewers:
lpromero
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, stkhapugin, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Open in New Tab method for Reading List Delegate This CL exposes the Open in New Tab and Open in New Incognito Tab methods of the Reading List Coordinator as part of the ReadingListCollectionViewControllerDelegate. BUG=676290 Review-Url: https://codereview.chromium.org/2745563002 Cr-Commit-Position: refs/heads/master@{#455744} Committed: https://chromium.googlesource.com/chromium/src/+/2baf6ccd85a3c9546ca6bdd5482e8c77dd1ed87a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -40 lines) Patch
M ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.h View 2 chunks +16 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/reading_list/reading_list_coordinator.mm View 6 chunks +22 lines, -40 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
gambard
PTAL.
3 years, 9 months ago (2017-03-09 13:46:18 UTC) #2
lpromero
lgtm
3 years, 9 months ago (2017-03-09 14:35:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745563002/1
3 years, 9 months ago (2017-03-09 14:35:25 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 14:48:47 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2baf6ccd85a3c9546ca6bdd5482e...

Powered by Google App Engine
This is Rietveld 408576698