Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2740833003: Refactor ReadingListCollectionViewController (Closed)

Created:
3 years, 9 months ago by gambard
Modified:
3 years, 9 months ago
Reviewers:
Olivier, lpromero
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, stkhapugin, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor ReadingListCollectionViewController Add arguments to the editing functions. BUG=676290 Review-Url: https://codereview.chromium.org/2740833003 Cr-Commit-Position: refs/heads/master@{#455748} Committed: https://chromium.googlesource.com/chromium/src/+/dce9f6e285ea530bc2350ae082c1ba29af929553

Patch Set 1 #

Total comments: 2

Patch Set 2 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -57 lines) Patch
M ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm View 1 10 chunks +52 lines, -57 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
gambard
PTAL.
3 years, 9 months ago (2017-03-09 14:06:27 UTC) #2
gambard
+olivierrobin, PTAL.
3 years, 9 months ago (2017-03-09 14:22:50 UTC) #4
lpromero
lgtm https://codereview.chromium.org/2740833003/diff/1/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm File ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm (right): https://codereview.chromium.org/2740833003/diff/1/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm#newcode931 ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm:931: } Fix indent here and below (or git ...
3 years, 9 months ago (2017-03-09 14:33:33 UTC) #5
gambard
Thanks! https://codereview.chromium.org/2740833003/diff/1/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm File ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm (right): https://codereview.chromium.org/2740833003/diff/1/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm#newcode931 ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm:931: } On 2017/03/09 14:33:33, lpromero wrote: > Fix ...
3 years, 9 months ago (2017-03-09 14:54:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2740833003/20001
3 years, 9 months ago (2017-03-09 14:54:27 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/dce9f6e285ea530bc2350ae082c1ba29af929553
3 years, 9 months ago (2017-03-09 15:12:46 UTC) #12
Olivier
3 years, 9 months ago (2017-03-09 18:26:46 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698