Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2745483002: Ensure that we can repeatedly set an expando on a plugin object (Closed)

Created:
3 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Ensure that we can repeatedly set an expando on a plugin object Just checking whether the holder has the property in the setter interceptor doesn't work, as this will invoke the get interceptor. BUG=691142 TBR=haraken@chromium.org Review-Url: https://codereview.chromium.org/2736783002 Cr-Commit-Position: refs/heads/master@{#455109} (cherry picked from commit 7acd424e3b6884424a4ab9df5ca9c8ab0f5a074d) Review-Url: https://codereview.chromium.org/2745483002 . Cr-Commit-Position: refs/branch-heads/3029@{#81} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/bd3dc76cf5f0040beefa918e56277e2867294c4c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/plugins/simple-expando.html View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp View 2 chunks +9 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jochen (gone - plz use gerrit)
3 years, 9 months ago (2017-03-09 08:03:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bd3dc76cf5f0040beefa918e56277e2867294c4c.

Powered by Google App Engine
This is Rietveld 408576698