Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2736783002:
Ensure that we can repeatedly set an expando on a plugin object (Closed)
|
Created:
3 years, 9 months ago by jochen (gone - plz use gerrit) Modified:
3 years, 9 months ago Reviewers:
haraken CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnsure that we can repeatedly set an expando on a plugin object
Just checking whether the holder has the property in the setter
interceptor doesn't work, as this will invoke the get interceptor.
BUG=691142
R=haraken@chromium.org
Review-Url: https://codereview.chromium.org/2736783002
Cr-Commit-Position: refs/heads/master@{#455109}
Committed: https://chromium.googlesource.com/chromium/src/+/7acd424e3b6884424a4ab9df5ca9c8ab0f5a074d
Patch Set 1 #Patch Set 2 : updates #
Messages
Total messages: 23 (15 generated)
The CQ bit was checked by jochen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM
The CQ bit was unchecked by jochen@chromium.org
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by jochen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Ensure that we can repeatedly set an expando on a plugin object Just checking whether the holder has the property in the setter interceptor doesn't work, as this will invoke the get interceptor. Use HasRealNamedProperty instead which skips interceptors. BUG=691142 R=haraken@chromium.org ========== to ========== Ensure that we can repeatedly set an expando on a plugin object Just checking whether the holder has the property in the setter interceptor doesn't work, as this will invoke the get interceptor. BUG=691142 R=haraken@chromium.org ==========
The CQ bit was unchecked by jochen@chromium.org
The CQ bit was checked by jochen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org Link to the patchset: https://codereview.chromium.org/2736783002/#ps20001 (title: "updates")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by jochen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488901298623500,
"parent_rev": "3bdf8977c45b8073999d40f2f7ec0f56dce7aec4", "commit_rev":
"7acd424e3b6884424a4ab9df5ca9c8ab0f5a074d"}
Message was sent while issue was closed.
Description was changed from ========== Ensure that we can repeatedly set an expando on a plugin object Just checking whether the holder has the property in the setter interceptor doesn't work, as this will invoke the get interceptor. BUG=691142 R=haraken@chromium.org ========== to ========== Ensure that we can repeatedly set an expando on a plugin object Just checking whether the holder has the property in the setter interceptor doesn't work, as this will invoke the get interceptor. BUG=691142 R=haraken@chromium.org Review-Url: https://codereview.chromium.org/2736783002 Cr-Commit-Position: refs/heads/master@{#455109} Committed: https://chromium.googlesource.com/chromium/src/+/7acd424e3b6884424a4ab9df5ca9... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/7acd424e3b6884424a4ab9df5ca9... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
