Chromium Code Reviews
DescriptionAdd requesting origin param to PermissionManager::GetPermissionStatusForFrame
GetPermissionStatusForFrame was currently added to facilitate permission
checks which require knowledge of the frame that is the source of the
permission request. Although we can determine the origin of that frame
directly through GetLastCommittedURL, we can't currently make the assumption
in Chrome that this origin matches the one passed down to various
callsites of GetPermissionStatus currently. crbug.com/698985 is
investigating that issue, however there are other reasons to have this
function, such as using it to incorporate Android permission checks and adding
permission delegation checks. Hence we pass in the requesting origin as well
for now and hopefully we can remove it again when crbug.com/698985 is resolved.
BUG=596786
Review-Url: https://codereview.chromium.org/2745453002
Cr-Commit-Position: refs/heads/master@{#456324}
Committed: https://chromium.googlesource.com/chromium/src/+/79f22a61dfa4d5a026bd3c75b8b04bbcdeae0c1d
Patch Set 1 #
Messages
Total messages: 12 (8 generated)
|
||||||||||||||||||||||||||||