Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Issue 2745453002: Add requesting origin param to PermissionManager::GetPermissionStatusForFrame (Closed)

Created:
3 years, 9 months ago by raymes
Modified:
3 years, 9 months ago
Reviewers:
benwells
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org, raymes+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add requesting origin param to PermissionManager::GetPermissionStatusForFrame GetPermissionStatusForFrame was currently added to facilitate permission checks which require knowledge of the frame that is the source of the permission request. Although we can determine the origin of that frame directly through GetLastCommittedURL, we can't currently make the assumption in Chrome that this origin matches the one passed down to various callsites of GetPermissionStatus currently. crbug.com/698985 is investigating that issue, however there are other reasons to have this function, such as using it to incorporate Android permission checks and adding permission delegation checks. Hence we pass in the requesting origin as well for now and hopefully we can remove it again when crbug.com/698985 is resolved. BUG=596786 Review-Url: https://codereview.chromium.org/2745453002 Cr-Commit-Position: refs/heads/master@{#456324} Committed: https://chromium.googlesource.com/chromium/src/+/79f22a61dfa4d5a026bd3c75b8b04bbcdeae0c1d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M chrome/browser/permissions/permission_manager.h View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/permissions/permission_manager.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
raymes
3 years, 9 months ago (2017-03-09 04:08:18 UTC) #2
benwells
lgtm
3 years, 9 months ago (2017-03-09 04:50:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745453002/1
3 years, 9 months ago (2017-03-13 04:28:39 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 05:29:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/79f22a61dfa4d5a026bd3c75b8b0...

Powered by Google App Engine
This is Rietveld 408576698