Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2049)

Unified Diff: chrome/browser/permissions/permission_manager.h

Issue 2745453002: Add requesting origin param to PermissionManager::GetPermissionStatusForFrame (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/permissions/permission_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_manager.h
diff --git a/chrome/browser/permissions/permission_manager.h b/chrome/browser/permissions/permission_manager.h
index 979b91e1a0d5bbf63230e621052ffcfd5a9e9f2c..0dbc1cfd046e86281a902e7bea0121c455a0e7ef 100644
--- a/chrome/browser/permissions/permission_manager.h
+++ b/chrome/browser/permissions/permission_manager.h
@@ -58,9 +58,13 @@ class PermissionManager : public KeyedService,
// Returns the permission status for a given frame. This should be preferred
// over GetPermissionStatus as additional checks can be performed when we know
// the exact context the request is coming from.
+ // TODO(raymes): Currently we still pass the |requesting_origin| as a separate
+ // parameter because we can't yet guarantee that it matches the last committed
+ // origin of the RenderFrameHost. See crbug.com/698985.
PermissionResult GetPermissionStatusForFrame(
ContentSettingsType permission,
- content::RenderFrameHost* render_frame_host);
+ content::RenderFrameHost* render_frame_host,
+ const GURL& requesting_origin);
// content::PermissionManager implementation.
int RequestPermission(
« no previous file with comments | « no previous file | chrome/browser/permissions/permission_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698