DOM Range: surroundContents() should not check if newParent is in ancestors beforehand.

DOM Range: surroundContents() should not check if newParent is in ancestors beforehand.

https://dom.spec.whatwg.org/#dom-range-surroundcontents
According to the DOM standard, we should not check it before starting DOM
mutation. Step 5 throws HierarchyRequestError instead.

This CL fixes 44 tests in wpt/dom/ranges/Range-surroundContents.html.


* images/element-gcd-while-generating-alt-content.html: Removed.
  This CL changes behavior of the test. The test was for a crash bug in
  pre-Olilpan era, and we don't have code for the crash fix any longer.

* fast/dom/Range/surroundContents-1.html: Removed.
  This is a pixel test to verify HierarchyRequestError which this CL removes.
  This behavior is tested well in WPT.

* shadow-dom/range-surround-contents.html: Updated
  DOM trees are modified because this CL removes a precondition check.

BUG=699861
Review-Url: https://codereview.chromium.org/2745443003
Cr-Commit-Position: refs/heads/master@{#455941}
Committed: https://chromium.googlesource.com/chromium/src/+/a3c94e4cc81caa2693ee56579e74c71e2fcadb0f

[tkent, 2017-03-09 04:22:22]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 04:22:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 05:14:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 05:14:54]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tkent, 2017-03-09 07:18:02]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 07:18:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-03-09 07:23:22]

Description was changed from

==========
DOM Range: surroundContents() should not check if newParent is in ancestors
beforehand.

BUG=699861
==========

to

==========
DOM Range: surroundContents() should not check if newParent is in ancestors
beforehand.

* images/element-gcd-while-generating-alt-content.html:
  This CL changes behavior of the test. The test was for a crash bug in
  pre-Olilpan era, and we don't have code for the crash fix any longer.
  So this CL removes it.

* 

BUG=699861
==========

[tkent, 2017-03-09 07:25:02]

Description was changed from

==========
DOM Range: surroundContents() should not check if newParent is in ancestors
beforehand.

* images/element-gcd-while-generating-alt-content.html:
  This CL changes behavior of the test. The test was for a crash bug in
  pre-Olilpan era, and we don't have code for the crash fix any longer.
  So this CL removes it.

* 

BUG=699861
==========

to

==========
DOM Range: surroundContents() should not check if newParent is in ancestors
beforehand.

* images/element-gcd-while-generating-alt-content.html: Removed.
  This CL changes behavior of the test. The test was for a crash bug in
  pre-Olilpan era, and we don't have code for the crash fix any longer.

* fast/dom/Range/surroundContents-1.html: Removed.
  This is a pixel test to verify HierarchyRequestError which this CL removes.
  This behavior is tested well in WPT.

BUG=699861
==========

[tkent, 2017-03-09 07:33:12]

Description was changed from

==========
DOM Range: surroundContents() should not check if newParent is in ancestors
beforehand.

* images/element-gcd-while-generating-alt-content.html: Removed.
  This CL changes behavior of the test. The test was for a crash bug in
  pre-Olilpan era, and we don't have code for the crash fix any longer.

* fast/dom/Range/surroundContents-1.html: Removed.
  This is a pixel test to verify HierarchyRequestError which this CL removes.
  This behavior is tested well in WPT.

BUG=699861
==========

to

==========
DOM Range: surroundContents() should not check if newParent is in ancestors
beforehand.

* images/element-gcd-while-generating-alt-content.html: Removed.
  This CL changes behavior of the test. The test was for a crash bug in
  pre-Olilpan era, and we don't have code for the crash fix any longer.

* fast/dom/Range/surroundContents-1.html: Removed.
  This is a pixel test to verify HierarchyRequestError which this CL removes.
  This behavior is tested well in WPT.

* shadow-dom/range-surround-contents.html: Updated
  

BUG=699861
==========

[tkent, 2017-03-09 07:34:54]

Description was changed from

==========
DOM Range: surroundContents() should not check if newParent is in ancestors
beforehand.

* images/element-gcd-while-generating-alt-content.html: Removed.
  This CL changes behavior of the test. The test was for a crash bug in
  pre-Olilpan era, and we don't have code for the crash fix any longer.

* fast/dom/Range/surroundContents-1.html: Removed.
  This is a pixel test to verify HierarchyRequestError which this CL removes.
  This behavior is tested well in WPT.

* shadow-dom/range-surround-contents.html: Updated
  

BUG=699861
==========

to

==========
DOM Range: surroundContents() should not check if newParent is in ancestors
beforehand.

* images/element-gcd-while-generating-alt-content.html: Removed.
  This CL changes behavior of the test. The test was for a crash bug in
  pre-Olilpan era, and we don't have code for the crash fix any longer.

* fast/dom/Range/surroundContents-1.html: Removed.
  This is a pixel test to verify HierarchyRequestError which this CL removes.
  This behavior is tested well in WPT.

* shadow-dom/range-surround-contents.html: Updated
  DOM trees are modified because this CL removes a precondition check.

BUG=699861
==========

[tkent, 2017-03-09 07:53:49]

Description was changed from

==========
DOM Range: surroundContents() should not check if newParent is in ancestors
beforehand.

* images/element-gcd-while-generating-alt-content.html: Removed.
  This CL changes behavior of the test. The test was for a crash bug in
  pre-Olilpan era, and we don't have code for the crash fix any longer.

* fast/dom/Range/surroundContents-1.html: Removed.
  This is a pixel test to verify HierarchyRequestError which this CL removes.
  This behavior is tested well in WPT.

* shadow-dom/range-surround-contents.html: Updated
  DOM trees are modified because this CL removes a precondition check.

BUG=699861
==========

to

==========
DOM Range: surroundContents() should not check if newParent is in ancestors
beforehand.

https://dom.spec.whatwg.org/#dom-range-surroundcontents
According to the DOM standard, we should not check it before starting DOM
mutation. Step 5 throws HierarchyRequestError instead.

* images/element-gcd-while-generating-alt-content.html: Removed.
  This CL changes behavior of the test. The test was for a crash bug in
  pre-Olilpan era, and we don't have code for the crash fix any longer.

* fast/dom/Range/surroundContents-1.html: Removed.
  This is a pixel test to verify HierarchyRequestError which this CL removes.
  This behavior is tested well in WPT.

* shadow-dom/range-surround-contents.html: Updated
  DOM trees are modified because this CL removes a precondition check.

BUG=699861
==========

[commit-bot: I haz the power, 2017-03-09 09:05:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 09:06:00]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-03-09 22:36:32]

tkent@chromium.org changed reviewers:
+ yosin@chromium.org

[tkent, 2017-03-09 22:36:33]

yosin@, would you review this please?

https://codereview.chromium.org/2745443003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/Range.cpp (left):

https://codereview.chromium.org/2745443003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/Range.cpp:1398: // FIXME: Do we need a check
if the node would end up with a child node of a
This FIXME comment was bogus. The check already exist.

[tkent, 2017-03-09 22:37:07]

Description was changed from

==========
DOM Range: surroundContents() should not check if newParent is in ancestors
beforehand.

https://dom.spec.whatwg.org/#dom-range-surroundcontents
According to the DOM standard, we should not check it before starting DOM
mutation. Step 5 throws HierarchyRequestError instead.

* images/element-gcd-while-generating-alt-content.html: Removed.
  This CL changes behavior of the test. The test was for a crash bug in
  pre-Olilpan era, and we don't have code for the crash fix any longer.

* fast/dom/Range/surroundContents-1.html: Removed.
  This is a pixel test to verify HierarchyRequestError which this CL removes.
  This behavior is tested well in WPT.

* shadow-dom/range-surround-contents.html: Updated
  DOM trees are modified because this CL removes a precondition check.

BUG=699861
==========

to

==========
DOM Range: surroundContents() should not check if newParent is in ancestors
beforehand.

https://dom.spec.whatwg.org/#dom-range-surroundcontents
According to the DOM standard, we should not check it before starting DOM
mutation. Step 5 throws HierarchyRequestError instead.

This CL fixes 44 tests in wpt/dom/ranges/Range-surroundContents.html.


* images/element-gcd-while-generating-alt-content.html: Removed.
  This CL changes behavior of the test. The test was for a crash bug in
  pre-Olilpan era, and we don't have code for the crash fix any longer.

* fast/dom/Range/surroundContents-1.html: Removed.
  This is a pixel test to verify HierarchyRequestError which this CL removes.
  This behavior is tested well in WPT.

* shadow-dom/range-surround-contents.html: Updated
  DOM trees are modified because this CL removes a precondition check.

BUG=699861
==========

[yosin_UTC9, 2017-03-10 01:07:00]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-03-10 01:07:01]

lgtm

[commit-bot: I haz the power, 2017-03-10 01:07:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 01:15:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489108020301600,
"parent_rev": "337642ea1516b47bd972b0f980a0a71b19931dd2", "commit_rev":
"a3c94e4cc81caa2693ee56579e74c71e2fcadb0f"}

[commit-bot: I haz the power, 2017-03-10 01:16:07]

Description was changed from

==========
DOM Range: surroundContents() should not check if newParent is in ancestors
beforehand.

https://dom.spec.whatwg.org/#dom-range-surroundcontents
According to the DOM standard, we should not check it before starting DOM
mutation. Step 5 throws HierarchyRequestError instead.

This CL fixes 44 tests in wpt/dom/ranges/Range-surroundContents.html.


* images/element-gcd-while-generating-alt-content.html: Removed.
  This CL changes behavior of the test. The test was for a crash bug in
  pre-Olilpan era, and we don't have code for the crash fix any longer.

* fast/dom/Range/surroundContents-1.html: Removed.
  This is a pixel test to verify HierarchyRequestError which this CL removes.
  This behavior is tested well in WPT.

* shadow-dom/range-surround-contents.html: Updated
  DOM trees are modified because this CL removes a precondition check.

BUG=699861
==========

to

==========
DOM Range: surroundContents() should not check if newParent is in ancestors
beforehand.

https://dom.spec.whatwg.org/#dom-range-surroundcontents
According to the DOM standard, we should not check it before starting DOM
mutation. Step 5 throws HierarchyRequestError instead.

This CL fixes 44 tests in wpt/dom/ranges/Range-surroundContents.html.


* images/element-gcd-while-generating-alt-content.html: Removed.
  This CL changes behavior of the test. The test was for a crash bug in
  pre-Olilpan era, and we don't have code for the crash fix any longer.

* fast/dom/Range/surroundContents-1.html: Removed.
  This is a pixel test to verify HierarchyRequestError which this CL removes.
  This behavior is tested well in WPT.

* shadow-dom/range-surround-contents.html: Updated
  DOM trees are modified because this CL removes a precondition check.

BUG=699861

Review-Url: https://codereview.chromium.org/2745443003
Cr-Commit-Position: refs/heads/master@{#455941}
Committed:
https://chromium.googlesource.com/chromium/src/+/a3c94e4cc81caa2693ee56579e74...
==========

[commit-bot: I haz the power, 2017-03-10 01:16:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a3c94e4cc81caa2693ee56579e74...