third_party/WebKit/LayoutTests/shadow-dom/range-surround-contents.html - Issue 2745443003: DOM Range: surroundContents() should not check if newParent is in ancestors beforehand.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/shadow-dom/range-surround-contents.html

Issue 2745443003: DOM Range: surroundContents() should not check if newParent is in ancestors beforehand. (Closed)

Patch Set: . Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/platform/win/fast/dom/Range/surroundContents-1-expected.txt ('k') | third_party/WebKit/Source/core/dom/Range.cpp » ('j') | third_party/WebKit/Source/core/dom/Range.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/shadow-dom/range-surround-contents.html

diff --git a/third_party/WebKit/LayoutTests/shadow-dom/range-surround-contents.html b/third_party/WebKit/LayoutTests/shadow-dom/range-surround-contents.html

index 806466289c24abe1c924af055f6eb30f52592589..214f6a134092cf6b7afed07feed2341dcd75fe04 100644

--- a/third_party/WebKit/LayoutTests/shadow-dom/range-surround-contents.html

+++ b/third_party/WebKit/LayoutTests/shadow-dom/range-surround-contents.html

@@ -37,8 +37,7 @@ function testSurroundContents(description, targetPath, newParent) {

assert_throws("HierarchyRequestError", function () {

range.surroundContents(newParent);

});

- var targetAfter = getNodeInComposedTree(targetPath);

- assert_equals(targetAfter, target, "DOM should not change after HierarchyRequestError");

+ assert_equals(newParent.firstChild, null, newParent.id + " should not have children after surroundContents()");

}, description);

}