Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Issue 2745413005: [scheduler] Move DatabaseAccess tasks to loading tq. (Closed)

Created:
3 years, 9 months ago by Sami
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[scheduler] Move DatabaseAccess tasks to loading tq. Posting DatabaseAccess tasks to unthrottled task queue can lead to running websql callbacks when the page is suspended, and it will cause callback to cancel itself. Post DatabaseAccess tasks to loading queue, which can be suspended and make sure that these tasks run only when page isn't suspended. R=haraken@chromium.org CC=skyostil@chromium.org BUG=700792 Review-Url: https://codereview.chromium.org/2752003002 Cr-Commit-Position: refs/heads/master@{#457145} (cherry picked from commit 27e68ff784ac0798b46bc596434dd50fbd673887) Review-Url: https://codereview.chromium.org/2745413005 . Cr-Commit-Position: refs/branch-heads/2987@{#826} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/faad12b9a164462d05626473b8caac31281d4fb6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/dom/TaskRunnerHelper.cpp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Sami
3 years, 9 months ago (2017-03-15 18:46:45 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
faad12b9a164462d05626473b8caac31281d4fb6.

Powered by Google App Engine
This is Rietveld 408576698