Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 2752003002: [scheduler] Move DatabaseAccess tasks to loading tq. (Closed)

Created:
3 years, 9 months ago by altimin
Modified:
3 years, 9 months ago
Reviewers:
haraken, Sami
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis, Sami
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[scheduler] Move DatabaseAccess tasks to loading tq. Posting DatabaseAccess tasks to unthrottled task queue can lead to running websql callbacks when the page is suspended, and it will cause callback to cancel itself. Post DatabaseAccess tasks to loading queue, which can be suspended and make sure that these tasks run only when page isn't suspended. R=haraken@chromium.org CC=skyostil@chromium.org BUG=700792 Review-Url: https://codereview.chromium.org/2752003002 Cr-Commit-Position: refs/heads/master@{#457145} Committed: https://chromium.googlesource.com/chromium/src/+/27e68ff784ac0798b46bc596434dd50fbd673887

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/dom/TaskRunnerHelper.cpp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
altimin
PTAL
3 years, 9 months ago (2017-03-15 16:46:00 UTC) #2
Sami
Non-owner lgtm.
3 years, 9 months ago (2017-03-15 16:50:37 UTC) #5
haraken
LGTM. Please add a more explanation to the CL description.
3 years, 9 months ago (2017-03-15 16:51:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2752003002/1
3 years, 9 months ago (2017-03-15 18:09:18 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 18:24:23 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/27e68ff784ac0798b46bc596434d...

Powered by Google App Engine
This is Rietveld 408576698