Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(12)

Issue 2745403002: Re-enable PlatformNotificationServiceBrowserTest.CheckFilePermissionNotGranted (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months, 1 week ago by dominickn
Modified:
7 months, 1 week ago
Reviewers:
Peter Beverloo
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable PlatformNotificationServiceBrowserTest.CheckFilePermissionNotGranted This test no longer DCHECK fails. BUG=502057 Review-Url: https://codereview.chromium.org/2745403002 Cr-Commit-Position: refs/heads/master@{#456829} Committed: https://chromium.googlesource.com/chromium/src/+/65dcca5f8602932cb80baf9b0b2c739bcca41495

Patch Set 1 #

Messages

Total messages: 12 (8 generated)
dominickn
PTAL, thanks!
7 months, 1 week ago (2017-03-14 05:37:34 UTC) #6
Peter Beverloo
lgtm *dances*
7 months, 1 week ago (2017-03-14 17:31:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745403002/1
7 months, 1 week ago (2017-03-14 21:03:30 UTC) #9
commit-bot: I haz the power
7 months, 1 week ago (2017-03-14 21:12:40 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/65dcca5f8602932cb80baf9b0b2c...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa