Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6620)

Unified Diff: chrome/browser/notifications/platform_notification_service_interactive_uitest.cc

Issue 2745403002: Re-enable PlatformNotificationServiceBrowserTest.CheckFilePermissionNotGranted (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
diff --git a/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc b/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
index 1d29b9cf76985a3f5f54cbcbb5e3e0042c7de297..2314d241b4c66bfb50afb9f694ccba952df448a0 100644
--- a/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
+++ b/chrome/browser/notifications/platform_notification_service_interactive_uitest.cc
@@ -461,10 +461,8 @@ IN_PROC_BROWSER_TEST_F(PlatformNotificationServiceBrowserTest,
EXPECT_EQ(TestPageUrl().spec(), notification.service_worker_scope().spec());
}
-// TODO(felt): This DCHECKs when bubbles are enabled, when the file_url is
-// persisted. crbug.com/502057
IN_PROC_BROWSER_TEST_F(PlatformNotificationServiceBrowserTest,
- DISABLED_CheckFilePermissionNotGranted) {
+ CheckFilePermissionNotGranted) {
// This case should succeed because a normal page URL is used.
std::string script_result;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698