Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 2745373002: Fix remoting_unittests!BreakpadWinDeathTest.TestAccessViolation under WinASan (Closed)

Created:
3 years, 9 months ago by Reid Kleckner
Modified:
3 years, 9 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix remoting_unittests!BreakpadWinDeathTest.TestAccessViolation under WinASan The test should not expect to be called back for an access violation when ASan is present. ASan will override the unhandled exception filter and report such errors and terminate the process. R=sergeyu@chromium.org BUG=698848 Review-Url: https://codereview.chromium.org/2745373002 Cr-Commit-Position: refs/heads/master@{#456803} Committed: https://chromium.googlesource.com/chromium/src/+/1a9bed2a008dc2a98fa5f3af900a6bad79e5947f

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add #endif comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M remoting/base/breakpad_win_unittest.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Reid Kleckner
3 years, 9 months ago (2017-03-14 01:05:13 UTC) #1
Sergey Ulanov
lgtm https://codereview.chromium.org/2745373002/diff/1/remoting/base/breakpad_win_unittest.cc File remoting/base/breakpad_win_unittest.cc (right): https://codereview.chromium.org/2745373002/diff/1/remoting/base/breakpad_win_unittest.cc#newcode149 remoting/base/breakpad_win_unittest.cc:149: #endif // !defined(ADDRESS_SANITIZER)
3 years, 9 months ago (2017-03-14 19:44:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745373002/20001
3 years, 9 months ago (2017-03-14 19:50:28 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 20:09:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1a9bed2a008dc2a98fa5f3af900a...

Powered by Google App Engine
This is Rietveld 408576698