Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: remoting/base/breakpad_win_unittest.cc

Issue 2745373002: Fix remoting_unittests!BreakpadWinDeathTest.TestAccessViolation under WinASan (Closed)
Patch Set: Add #endif comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/base/breakpad_win_unittest.cc
diff --git a/remoting/base/breakpad_win_unittest.cc b/remoting/base/breakpad_win_unittest.cc
index f0da52cfdb5312043136c3a6f987f484a99f5276..38c368b30cab0720b41020ef8105b577442bedac 100644
--- a/remoting/base/breakpad_win_unittest.cc
+++ b/remoting/base/breakpad_win_unittest.cc
@@ -140,9 +140,13 @@ void BreakpadWinDeathTest::SetUp() {
}
TEST_F(BreakpadWinDeathTest, TestAccessViolation) {
+#if !defined(ADDRESS_SANITIZER)
+ // ASan overrides the user unhandled exception filter so we won't receive this
+ // callback.
if (callbacks_.get()) {
EXPECT_CALL(*callbacks_, OnClientDumpRequested());
}
+#endif // !defined(ADDRESS_SANITIZER)
// Generate access violation exception.
ASSERT_DEATH(*reinterpret_cast<volatile int*>(NULL) = 1, "");
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698