Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2745323003: Add CrAppProtocol for headless on Mac (Closed)

Created:
3 years, 9 months ago by dvallet
Modified:
3 years, 9 months ago
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CrAppProtocol for headless on Mac This fixes a crash issue on Mac BUG=687407 Review-Url: https://codereview.chromium.org/2745323003 Cr-Commit-Position: refs/heads/master@{#457031} Committed: https://chromium.googlesource.com/chromium/src/+/c138025d59a66894f203432e08f0a92061297ec6

Patch Set 1 #

Patch Set 2 : Fix copyrighs #

Total comments: 4

Patch Set 3 : Added extra comments, fixed style #

Patch Set 4 : updated upstream, small nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
M headless/BUILD.gn View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M headless/lib/browser/headless_browser_main_parts.h View 1 chunk +3 lines, -0 lines 0 comments Download
A headless/lib/browser/headless_browser_main_parts_mac.mm View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
A headless/lib/browser/headless_shell_application_mac.h View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
A headless/lib/browser/headless_shell_application_mac.mm View 1 2 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 31 (19 generated)
dvallet
3 years, 9 months ago (2017-03-14 03:07:36 UTC) #6
Eric Seckler
lgtm with small nit, since this seems to be exactly what content shell does :) ...
3 years, 9 months ago (2017-03-14 08:27:53 UTC) #9
pfeldman
i am under pressure here, so i am pressing the cq. we fix comment :-)
3 years, 9 months ago (2017-03-14 08:31:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745323003/20001
3 years, 9 months ago (2017-03-14 08:31:59 UTC) #12
commit-bot: I haz the power
Failed to apply patch for headless/BUILD.gn: While running git apply --index -p1; error: patch failed: ...
3 years, 9 months ago (2017-03-14 08:36:29 UTC) #14
Robert Sesek
https://codereview.chromium.org/2745323003/diff/20001/headless/lib/browser/headless_shell_application_mac.h File headless/lib/browser/headless_shell_application_mac.h (right): https://codereview.chromium.org/2745323003/diff/20001/headless/lib/browser/headless_shell_application_mac.h#newcode14 headless/lib/browser/headless_shell_application_mac.h:14: BOOL handlingSendEvent_; Since this is new ObjC code, it ...
3 years, 9 months ago (2017-03-14 13:11:24 UTC) #16
dvallet
https://codereview.chromium.org/2745323003/diff/20001/headless/lib/browser/headless_shell_application_mac.h File headless/lib/browser/headless_shell_application_mac.h (right): https://codereview.chromium.org/2745323003/diff/20001/headless/lib/browser/headless_shell_application_mac.h#newcode11 headless/lib/browser/headless_shell_application_mac.h:11: @interface HeadlessShellCrApplication On 2017/03/14 08:27:53, Eric Seckler wrote: > ...
3 years, 9 months ago (2017-03-15 03:49:00 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745323003/40001
3 years, 9 months ago (2017-03-15 03:50:14 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/250552)
3 years, 9 months ago (2017-03-15 05:45:53 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745323003/40001
3 years, 9 months ago (2017-03-15 06:05:40 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745323003/60001
3 years, 9 months ago (2017-03-15 06:54:43 UTC) #28
commit-bot: I haz the power
3 years, 9 months ago (2017-03-15 08:14:47 UTC) #31
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c138025d59a66894f203432e08f0...

Powered by Google App Engine
This is Rietveld 408576698