headless/lib/browser/headless_shell_application_mac.h - Issue 2745323003: Add CrAppProtocol for headless on Mac

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: headless/lib/browser/headless_shell_application_mac.h

Issue 2745323003: Add CrAppProtocol for headless on Mac (Closed)

Patch Set: Fix copyrighs Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef HEADLESS_LIB_BROWSER_HEADLESS_SHELL_APPLICATION_MAC_H_

	6 #define HEADLESS_LIB_BROWSER_HEADLESS_SHELL_APPLICATION_MAC_H_

	7

	8 #include "base/mac/scoped_sending_event.h"

	9 #include "base/message_loop/message_pump_mac.h"

	10

	11 @interface HeadlessShellCrApplication
	Eric Seckler 2017/03/14 08:27:53 Can we add a comment somewhere why we need this Ns Can we add a comment somewhere why we need this NsApp subclass? Why do we need to "handle" events (by dropping them?) for screenshots? dvallet 2017/03/15 03:49:00 Done. I've also removed some unnecessary function, Show quoted text On 2017/03/14 08:27:53, Eric Seckler wrote: > Can we add a comment somewhere why we need this NsApp subclass? Why do we need > to "handle" events (by dropping them?) for screenshots? Done. I've also removed some unnecessary function, although I think I'll have to add them later.
	12 : NSApplication<CrAppProtocol, CrAppControlProtocol> {

	13 @private

	14 BOOL handlingSendEvent_;
	Robert Sesek 2017/03/14 13:11:24 Since this is new ObjC code, it should be written Since this is new ObjC code, it should be written in the modern style: you can move the ivar into the .mm file to hide it. dvallet 2017/03/15 03:49:00 Done. Thanks for checking! Show quoted text On 2017/03/14 13:11:24, Robert Sesek wrote: > Since this is new ObjC code, it should be written in the modern style: you can > move the ivar into the .mm file to hide it. Done. Thanks for checking!
	15 }

	16

	17 // CrAppProtocol:

	18 - (BOOL)isHandlingSendEvent;

	19

	20 // CrAppControlProtocol:

	21 - (void)setHandlingSendEvent:(BOOL)handlingSendEvent;

	22

	23 @end

	24

	25 #endif // HEADLESS_LIB_BROWSER_HEADLESS_SHELL_APPLICATION_MAC_H_

OLD	NEW

« no previous file with comments | « headless/lib/browser/headless_browser_main_parts_mac.mm ('k') | headless/lib/browser/headless_shell_application_mac.mm » ('j') | no next file with comments »