Set prototype for GuestView*.prototype to null.

Set prototype for GuestView*.prototype to null.

In order to prevent unintended user-code execution, don't allow
GuestView* classes to inherit code from the global object.

BUG=700685
Review-Url: https://codereview.chromium.org/2745173002
Cr-Commit-Position: refs/heads/master@{#456498}
Committed: https://chromium.googlesource.com/chromium/src/+/67eb49a4c6b8101b5790a9abade4315e494c58b8

[wjmaclean, 2017-03-13 14:14:17]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 14:14:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wjmaclean, 2017-03-13 14:14:39]

Description was changed from

==========
Set prototype for GuestViewEvents.prototype to null.

In order to prevent unintended user-code execution, don't allow
GuestViewEvents to inherit code from the global object.

BUG=700685
==========

to

==========
Set prototype for GuestViewEvents.prototype to null.

In order to prevent unintended user-code execution, don't allow
GuestViewEvents to inherit code from the global object.

BUG=700685
==========

[wjmaclean, 2017-03-13 14:14:39]

wjmaclean@chromium.org changed reviewers:
+ lazyboy@chromium.org

[commit-bot: I haz the power, 2017-03-13 14:21:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 14:21:28]

Dry run: This issue passed the CQ dry run.

[wjmaclean, 2017-03-13 15:15:01]

lazyboy@ - PTAL?

[lazyboy, 2017-03-13 18:15:14]

https://codereview.chromium.org/2745173002/diff/1/extensions/renderer/resourc...
File extensions/renderer/resources/guest_view/guest_view_events.js (right):

https://codereview.chromium.org/2745173002/diff/1/extensions/renderer/resourc...
extensions/renderer/resources/guest_view/guest_view_events.js:30: // Prevent
GuestViewEvents inadvertently inheritng code from the global Object,
OK.
How about adding WebViewActionRequest and guest_view_attributes.js:Attribute as
well? Are there more?

[wjmaclean, 2017-03-13 19:33:12]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 19:33:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wjmaclean, 2017-03-13 19:33:56]

Description was changed from

==========
Set prototype for GuestViewEvents.prototype to null.

In order to prevent unintended user-code execution, don't allow
GuestViewEvents to inherit code from the global object.

BUG=700685
==========

to

==========
Set prototype for GuestView*.prototype to null.

In order to prevent unintended user-code execution, don't allow
GuestView* classes to inherit code from the global object.

BUG=700685
==========

[wjmaclean, 2017-03-13 19:34:48]

Updated, ptal? I did a mnual search, and I think we have most, if not all, the
instances, but I'm not a JS expert so we'll keep looking.

https://codereview.chromium.org/2745173002/diff/1/extensions/renderer/resourc...
File extensions/renderer/resources/guest_view/guest_view_events.js (right):

https://codereview.chromium.org/2745173002/diff/1/extensions/renderer/resourc...
extensions/renderer/resources/guest_view/guest_view_events.js:30: // Prevent
GuestViewEvents inadvertently inheritng code from the global Object,
On 2017/03/13 18:15:14, lazyboy wrote:
> OK.
> How about adding WebViewActionRequest and guest_view_attributes.js:Attribute
as
> well? Are there more?

Done.

Will update. Yes, we are looking for more, but that search may take a while and
shouldn't block landing this CL.

[commit-bot: I haz the power, 2017-03-13 19:44:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 19:44:15]

Dry run: This issue passed the CQ dry run.

[lazyboy, 2017-03-13 19:46:06]

lgtm

https://codereview.chromium.org/2745173002/diff/1/extensions/renderer/resourc...
File extensions/renderer/resources/guest_view/guest_view_events.js (right):

https://codereview.chromium.org/2745173002/diff/1/extensions/renderer/resourc...
extensions/renderer/resources/guest_view/guest_view_events.js:30: // Prevent
GuestViewEvents inadvertently inheritng code from the global Object,
On 2017/03/13 19:34:48, wjmaclean wrote:
> On 2017/03/13 18:15:14, lazyboy wrote:
> > OK.
> > How about adding WebViewActionRequest and guest_view_attributes.js:Attribute
> as
> > well? Are there more?
> 
> Done.
> 
> Will update. Yes, we are looking for more, but that search may take a while
and
> shouldn't block landing this CL.

Acknowledged.

[wjmaclean, 2017-03-13 19:51:30]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 19:51:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 19:57:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 19:57:36]

Dry run: This issue passed the CQ dry run.

[wjmaclean, 2017-03-13 19:57:58]

The CQ bit was checked by wjmaclean@chromium.org

[commit-bot: I haz the power, 2017-03-13 19:58:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 21:38:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489435078280240,
"parent_rev": "41fd546edd6cb8dca649b193fad39c4a86547850", "commit_rev":
"67eb49a4c6b8101b5790a9abade4315e494c58b8"}

[commit-bot: I haz the power, 2017-03-13 21:39:28]

Description was changed from

==========
Set prototype for GuestView*.prototype to null.

In order to prevent unintended user-code execution, don't allow
GuestView* classes to inherit code from the global object.

BUG=700685
==========

to

==========
Set prototype for GuestView*.prototype to null.

In order to prevent unintended user-code execution, don't allow
GuestView* classes to inherit code from the global object.

BUG=700685

Review-Url: https://codereview.chromium.org/2745173002
Cr-Commit-Position: refs/heads/master@{#456498}
Committed:
https://chromium.googlesource.com/chromium/src/+/67eb49a4c6b8101b5790a9abade4...
==========

[commit-bot: I haz the power, 2017-03-13 21:39:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/67eb49a4c6b8101b5790a9abade4...