extensions/renderer/resources/guest_view/guest_view.js - Issue 2745173002: Set prototype for GuestView*.prototype to null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/guest_view/guest_view.js

Issue 2745173002: Set prototype for GuestView*.prototype to null. (Closed)

Patch Set: More nulls. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/resources/guest_view/guest_view.js

diff --git a/extensions/renderer/resources/guest_view/guest_view.js b/extensions/renderer/resources/guest_view/guest_view.js

index 4ab0e571d68f0030ddebc1d068619dfce7c3d0ad..19a035f1c1e38bf0e6ca62a294d2d3f2536f2e0c 100644

--- a/extensions/renderer/resources/guest_view/guest_view.js

+++ b/extensions/renderer/resources/guest_view/guest_view.js

@@ -48,6 +48,8 @@ function GuestViewImpl(guestView, viewType, guestInstanceId) {

// Prevent GuestViewImpl inadvertently inheriting code from the global Object,

// allowing a pathway for executing unintended user code execution.

+// TODO(wjmaclean): Use utils.expose() here instead? Track down other issues

+// of Object inheritance. https://crbug.com/701034

GuestViewImpl.prototype.__proto__ = null;

// Possible states.

« no previous file with comments | « no previous file | extensions/renderer/resources/guest_view/guest_view_attributes.js » ('j') | no next file with comments »