Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2745153002: Browser plugin should never handle MouseWheels. (Closed)

Created:
3 years, 9 months ago by wjmaclean
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Browser plugin should never handle MouseWheels. Now that we do direct routing of MouseWheel events to guests, BrowserPlugin should (1) never mark a MouseWheel as handled (this may cancel GesturePinch on Mac), and (2) it should never forward the MouseWheel to the guest. This CL implements this policy. BUG=695907 Review-Url: https://codereview.chromium.org/2745783002 Cr-Commit-Position: refs/heads/master@{#456125} (cherry picked from commit 1bbc9fc2b43ec7b02f5f781ffb70675c5def4220) Review-Url: https://codereview.chromium.org/2745153002 . Cr-Commit-Position: refs/branch-heads/3029@{#147} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/27a8e4ccda5f7215f452891b5f66f167cbdc4004

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M content/renderer/browser_plugin/browser_plugin.cc View 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
wjmaclean
3 years, 9 months ago (2017-03-13 14:00:34 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
27a8e4ccda5f7215f452891b5f66f167cbdc4004.

Powered by Google App Engine
This is Rietveld 408576698