Browser plugin should never handle MouseWheels.

Browser plugin should never handle MouseWheels.

Now that we do direct routing of MouseWheel events to guests,
BrowserPlugin should (1) never mark a MouseWheel as handled (this may
cancel GesturePinch on Mac), and (2) it should never forward the
MouseWheel to the guest. This CL implements this policy.

BUG=695907
Review-Url: https://codereview.chromium.org/2745783002
Cr-Commit-Position: refs/heads/master@{#456125}
Committed: https://chromium.googlesource.com/chromium/src/+/1bbc9fc2b43ec7b02f5f781ffb70675c5def4220

[wjmaclean, 2017-03-10 16:37:26]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[wjmaclean, 2017-03-10 16:37:42]

Description was changed from

==========
Browser plugin should never handle MouseWheels.

Now that we do direct routing of MouseWheel events to guests,
BrowserPlugin should (1) never mark a MouseWheel as handled (this may
cancel GesturePinch on Mac), and (2) it should never forward the
MouseWheel to the guest. This CL implements this policy.

BUG=695907
==========

to

==========
Browser plugin should never handle MouseWheels.

Now that we do direct routing of MouseWheel events to guests,
BrowserPlugin should (1) never mark a MouseWheel as handled (this may
cancel GesturePinch on Mac), and (2) it should never forward the
MouseWheel to the guest. This CL implements this policy.

BUG=695907
==========

[wjmaclean, 2017-03-10 16:37:42]

wjmaclean@chromium.org changed reviewers:
+ avallee@chromium.org

[commit-bot: I haz the power, 2017-03-10 16:37:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wjmaclean, 2017-03-10 16:38:03]

avallee@ - Could you please do a non-Owners review?

[avallee, 2017-03-10 17:03:31]

LGTM.

I'm not sure exactly how this originally worked. This was preventing the
embedder or guest from getting the wheel events?

[wjmaclean, 2017-03-10 17:15:57]

On 2017/03/10 17:03:31, avallee wrote:
> LGTM.
> 
> I'm not sure exactly how this originally worked. This was preventing the
> embedder or guest from getting the wheel events?

Even before event-routing, I don't think it worked in all cases ... e.g. Mac
GesturePinch would still have been broken.

But the basic idea, as with other BrowserPlugin event handling, was that
BrowserPlugin would claim to have handled the vent, while quietly forwarding it
to the guest, which may or may not actually handle the event.

[commit-bot: I haz the power, 2017-03-10 17:57:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 17:57:09]

Dry run: This issue passed the CQ dry run.

[wjmaclean, 2017-03-10 18:10:01]

The CQ bit was checked by wjmaclean@chromium.org

[commit-bot: I haz the power, 2017-03-10 18:10:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 18:10:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 18:10:22]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[wjmaclean, 2017-03-10 18:38:00]

The CQ bit was checked by wjmaclean@chromium.org

[commit-bot: I haz the power, 2017-03-10 18:38:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 18:38:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-10 18:38:37]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Charlie Reis, 2017-03-10 18:44:08]

creis@chromium.org changed reviewers:
+ creis@chromium.org

[Charlie Reis, 2017-03-10 18:44:09]

RS LGTM, given avallee's review.  (Are there OOPIF tests covering this for when
we switch away from BrowserPlugin, so that we don't regress?)

[wjmaclean, 2017-03-10 19:06:08]

On 2017/03/10 18:44:09, Charlie Reis (slow) wrote:
> RS LGTM, given avallee's review.  (Are there OOPIF tests covering this for
when
> we switch away from BrowserPlugin, so that we don't regress?)

I'll have to investigate, but my guess is that, since GesturePinch from Mac only
ever gets sent to the mainframe, and in OOPIF there's no BrowserPlugin to lie
about the event's 'handled' status, that there's nothing left to test. But I
will manually verify that this doesn't show up on Mac+WebView+O)PIF just to be
sure.

[wjmaclean, 2017-03-10 19:06:16]

The CQ bit was checked by wjmaclean@chromium.org

[commit-bot: I haz the power, 2017-03-10 19:06:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 19:12:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489172776074010, "parent_rev":
"6e26494d0caa38a608ecd3c7852a58387dcaaf96", "commit_rev":
"1bbc9fc2b43ec7b02f5f781ffb70675c5def4220"}

[commit-bot: I haz the power, 2017-03-10 19:13:58]

Description was changed from

==========
Browser plugin should never handle MouseWheels.

Now that we do direct routing of MouseWheel events to guests,
BrowserPlugin should (1) never mark a MouseWheel as handled (this may
cancel GesturePinch on Mac), and (2) it should never forward the
MouseWheel to the guest. This CL implements this policy.

BUG=695907
==========

to

==========
Browser plugin should never handle MouseWheels.

Now that we do direct routing of MouseWheel events to guests,
BrowserPlugin should (1) never mark a MouseWheel as handled (this may
cancel GesturePinch on Mac), and (2) it should never forward the
MouseWheel to the guest. This CL implements this policy.

BUG=695907

Review-Url: https://codereview.chromium.org/2745783002
Cr-Commit-Position: refs/heads/master@{#456125}
Committed:
https://chromium.googlesource.com/chromium/src/+/1bbc9fc2b43ec7b02f5f781ffb70...
==========

[commit-bot: I haz the power, 2017-03-10 19:13:59]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1bbc9fc2b43ec7b02f5f781ffb70...

[wjmaclean, 2017-03-10 20:01:41]

On 2017/03/10 19:13:59, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/1bbc9fc2b43ec7b02f5f781ffb70...

I manually tested on Mac with --enable-feature=CrossProcessFramesForGuests, and
this issue does not arise there, even without this fix.