INPUT element: Fix a DCHECK failure in RadioInputType::findNextFocusableRadioButtonInGroup.

INPUT element: Fix a DCHECK failure in RadioInputType::findNextFocusableRadioButtonInGroup.

The function calls isFocusable(), and we need to make sure that the layout is up
to date.

BUG=697286
Review-Url: https://codereview.chromium.org/2745103008
Cr-Commit-Position: refs/heads/master@{#457007}
Committed: https://chromium.googlesource.com/chromium/src/+/2f2e671f3872dafcc110ac0fb5e6615e6898f88f

[tkent, 2017-03-15 00:37:56]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 00:38:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 02:13:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 02:13:47]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-03-15 02:16:32]

tkent@chromium.org changed reviewers:
+ kochi@chromium.org

[tkent, 2017-03-15 02:16:32]

kochi@, would you review this please?
Unfortunately, I couldn't reproduce the DCHECK failure.

[tkent, 2017-03-15 03:14:30]

Offline discussion: we should try making a C++ unit test.

[tkent, 2017-03-15 04:08:49]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 04:09:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-03-15 04:09:24]

Description was changed from

==========
Speculative fix for a DCHECK failure in
RadioInputType::findNextFocusableRadioButtonInGroup.

The function calls isFocusable(), and we need to make sure that the layout is up
to date.

This CL has no tests because we couldn't reproduce the issue locally.

BUG=697286
==========

to

==========
INPUT element: Fix a DCHECK failure in
RadioInputType::findNextFocusableRadioButtonInGroup.

The function calls isFocusable(), and we need to make sure that the layout is up
to date.

BUG=697286
==========

[tkent, 2017-03-15 04:09:43]

On 2017/03/15 at 03:14:30, tkent wrote:
> Offline discussion: we should try making a C++ unit test.

Added a C++ unit test.  Please take a look at this again.

[kochi, 2017-03-15 04:28:40]

Thanks! LGTM.

[commit-bot: I haz the power, 2017-03-15 06:06:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 06:06:02]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-03-15 06:06:52]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2017-03-15 06:07:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 06:11:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489558012433120,
"parent_rev": "813bbc674ed1dc64cc40fb24c46944b51cf7c6bf", "commit_rev":
"2f2e671f3872dafcc110ac0fb5e6615e6898f88f"}

[commit-bot: I haz the power, 2017-03-15 06:13:20]

Description was changed from

==========
INPUT element: Fix a DCHECK failure in
RadioInputType::findNextFocusableRadioButtonInGroup.

The function calls isFocusable(), and we need to make sure that the layout is up
to date.

BUG=697286
==========

to

==========
INPUT element: Fix a DCHECK failure in
RadioInputType::findNextFocusableRadioButtonInGroup.

The function calls isFocusable(), and we need to make sure that the layout is up
to date.

BUG=697286

Review-Url: https://codereview.chromium.org/2745103008
Cr-Commit-Position: refs/heads/master@{#457007}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f2e671f3872dafcc110ac0fb5e6...
==========

[commit-bot: I haz the power, 2017-03-15 06:13:21]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2f2e671f3872dafcc110ac0fb5e6...