Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLInputElement.h

Issue 2745103008: INPUT element: Fix a DCHECK failure in RadioInputType::findNextFocusableRadioButtonInGroup. (Closed)
Patch Set: Add C++ unit test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.
6 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 6 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
11 * version 2 of the License, or (at your option) any later version. 11 * version 2 of the License, or (at your option) any later version.
12 * 12 *
13 * This library is distributed in the hope that it will be useful, 13 * This library is distributed in the hope that it will be useful,
14 * but WITHOUT ANY WARRANTY; without even the implied warranty of 14 * but WITHOUT ANY WARRANTY; without even the implied warranty of
15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 15 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
16 * Library General Public License for more details. 16 * Library General Public License for more details.
17 * 17 *
18 * You should have received a copy of the GNU Library General Public License 18 * You should have received a copy of the GNU Library General Public License
19 * along with this library; see the file COPYING.LIB. If not, write to 19 * along with this library; see the file COPYING.LIB. If not, write to
20 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 20 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
21 * Boston, MA 02110-1301, USA. 21 * Boston, MA 02110-1301, USA.
22 * 22 *
23 */ 23 */
24 24
25 #ifndef HTMLInputElement_h 25 #ifndef HTMLInputElement_h
26 #define HTMLInputElement_h 26 #define HTMLInputElement_h
27 27
28 #include "base/gtest_prod_util.h"
28 #include "core/CoreExport.h" 29 #include "core/CoreExport.h"
29 #include "core/html/TextControlElement.h" 30 #include "core/html/TextControlElement.h"
30 #include "core/html/forms/StepRange.h" 31 #include "core/html/forms/StepRange.h"
31 #include "platform/FileChooser.h" 32 #include "platform/FileChooser.h"
32 33
33 namespace blink { 34 namespace blink {
34 35
35 class AXObject; 36 class AXObject;
36 class DragData; 37 class DragData;
37 class ExceptionState; 38 class ExceptionState;
(...skipping 384 matching lines...) Expand 10 before | Expand all | Expand 10 after
422 unsigned m_needsToUpdateViewValue : 1; 423 unsigned m_needsToUpdateViewValue : 1;
423 unsigned m_isPlaceholderVisible : 1; 424 unsigned m_isPlaceholderVisible : 1;
424 Member<InputType> m_inputType; 425 Member<InputType> m_inputType;
425 Member<InputTypeView> m_inputTypeView; 426 Member<InputTypeView> m_inputTypeView;
426 // The ImageLoader must be owned by this element because the loader code 427 // The ImageLoader must be owned by this element because the loader code
427 // assumes that it lives as long as its owning element lives. If we move the 428 // assumes that it lives as long as its owning element lives. If we move the
428 // loader into the ImageInput object we may delete the loader while this 429 // loader into the ImageInput object we may delete the loader while this
429 // element lives on. 430 // element lives on.
430 Member<HTMLImageLoader> m_imageLoader; 431 Member<HTMLImageLoader> m_imageLoader;
431 Member<ListAttributeTargetObserver> m_listAttributeTargetObserver; 432 Member<ListAttributeTargetObserver> m_listAttributeTargetObserver;
433
434 FRIEND_TEST_ALL_PREFIXES(HTMLInputElementTest, RadioKeyDownDCHECKFailure);
432 }; 435 };
433 436
434 } // namespace blink 437 } // namespace blink
435 438
436 #endif // HTMLInputElement_h 439 #endif // HTMLInputElement_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/html/HTMLInputElementTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698