Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2745053002: Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chromecast/ (Closed)

Created:
3 years, 9 months ago by Byoungkwon Ko
Modified:
3 years, 9 months ago
Reviewers:
slan
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chromecast/ BUG=644626 Review-Url: https://codereview.chromium.org/2745053002 Cr-Commit-Position: refs/heads/master@{#456530} Committed: https://chromium.googlesource.com/chromium/src/+/f77572d8707409ac0c7721ded9c575873e50698d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chromecast/browser/url_request_context_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/media/cma/test/mock_frame_consumer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromecast/media/cma/test/mock_frame_provider.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
Byoungkwon Ko
PTAL
3 years, 9 months ago (2017-03-13 10:17:26 UTC) #6
slan
lgtm
3 years, 9 months ago (2017-03-13 14:31:45 UTC) #8
Byoungkwon Ko
3 years, 9 months ago (2017-03-13 23:01:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2745053002/1
3 years, 9 months ago (2017-03-13 23:03:13 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 23:14:44 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f77572d8707409ac0c7721ded9c5...

Powered by Google App Engine
This is Rietveld 408576698