chromecast/media/cma/test/mock_frame_consumer.cc - Issue 2745053002: Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chromecast/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/media/cma/test/mock_frame_consumer.cc

Issue 2745053002: Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chromecast/ (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromecast/media/cma/test/mock_frame_consumer.cc

diff --git a/chromecast/media/cma/test/mock_frame_consumer.cc b/chromecast/media/cma/test/mock_frame_consumer.cc

index 3c3dec6f3004e6540f9370f42ebb6dab16293c8a..8a32b1afe30f4d430fd9fc5e29a46ccc7d142214 100644

--- a/chromecast/media/cma/test/mock_frame_consumer.cc

+++ b/chromecast/media/cma/test/mock_frame_consumer.cc

@@ -34,7 +34,7 @@ void MockFrameConsumer::Configure(

std::unique_ptr<FrameGeneratorForTest> frame_generator) {

delayed_task_pattern_ = delayed_task_pattern;

last_read_aborted_by_flush_ = last_read_aborted_by_flush;

- frame_generator_.reset(frame_generator.release());

+ frame_generator_ = std::move(frame_generator);

}

void MockFrameConsumer::Start(const base::Closure& done_cb) {