Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2744793002:
Use highp for glCopyTexture2D where available (Closed)
DescriptionUse highp for glCopyTexture2D where available
This fixes artifacts in copied textures caused by insufficient precision in
"mediump" floats when used for sampling textures. On a Pixel XL, a mediump
only has 10 bits precision in fragment shaders, that apparently only works
fully for texture dimensions < 1024 pixels. Use "highp" if both GL_ES
and GL_FRAGMENT_PRECISION_HIGH are set for the shader.
(See the bug for more discussion and a proposed alternative patch.)
BUG=700031
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2744793002
Cr-Commit-Position: refs/heads/master@{#456012}
Committed: https://chromium.googlesource.com/chromium/src/+/72efd11d727f12bc45e74a1e6f7e379b3d6d5e2d
Patch Set 1 #
Messages
Total messages: 18 (12 generated)
Description was changed from ========== Use highp for glCopyTexture2D where available This fixes artifacts in copied textures caused by insufficient precision in "mediump" floats when used for sampling textures. On a Pixel XL, a mediump only has 10 bits precision in fragment shaders, that apparently only works fully for texture dimensions < 1024 pixels. Use "highp" if both GL_ES and GL_FRAGMENT_PRECISION_HIGH are set for the shader. (See the bug for more discussion and a proposed alternative patch.) BUG=700031 ========== to ========== Use highp for glCopyTexture2D where available This fixes artifacts in copied textures caused by insufficient precision in "mediump" floats when used for sampling textures. On a Pixel XL, a mediump only has 10 bits precision in fragment shaders, that apparently only works fully for texture dimensions < 1024 pixels. Use "highp" if both GL_ES and GL_FRAGMENT_PRECISION_HIGH are set for the shader. (See the bug for more discussion and a proposed alternative patch.) BUG=700031 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
Description was changed from ========== Use highp for glCopyTexture2D where available This fixes artifacts in copied textures caused by insufficient precision in "mediump" floats when used for sampling textures. On a Pixel XL, a mediump only has 10 bits precision in fragment shaders, that apparently only works fully for texture dimensions < 1024 pixels. Use "highp" if both GL_ES and GL_FRAGMENT_PRECISION_HIGH are set for the shader. (See the bug for more discussion and a proposed alternative patch.) BUG=700031 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Use highp for glCopyTexture2D where available This fixes artifacts in copied textures caused by insufficient precision in "mediump" floats when used for sampling textures. On a Pixel XL, a mediump only has 10 bits precision in fragment shaders, that apparently only works fully for texture dimensions < 1024 pixels. Use "highp" if both GL_ES and GL_FRAGMENT_PRECISION_HIGH are set for the shader. (See the bug for more discussion and a proposed alternative patch.) BUG=700031 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
klausw@chromium.org changed reviewers: + jbauman@chromium.org
On 2017/03/10 03:04:57, klausw wrote: > mailto:klausw@chromium.org changed reviewers: > + mailto:jbauman@chromium.org jbauman@, as noted in the linked bug, if the performance impact of moving from mediump to highp is a concern it should also be possible to use this variant conditionally for large textures where mediump would produce artifacts. What do you think seems appropriate?
lgtm
The CQ bit was checked by klausw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by klausw@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by klausw@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1489129836581850, "parent_rev":
"05c00d2035047fa9d210d95afedf8bd063bccc33", "commit_rev":
"72efd11d727f12bc45e74a1e6f7e379b3d6d5e2d"}
Message was sent while issue was closed.
Description was changed from ========== Use highp for glCopyTexture2D where available This fixes artifacts in copied textures caused by insufficient precision in "mediump" floats when used for sampling textures. On a Pixel XL, a mediump only has 10 bits precision in fragment shaders, that apparently only works fully for texture dimensions < 1024 pixels. Use "highp" if both GL_ES and GL_FRAGMENT_PRECISION_HIGH are set for the shader. (See the bug for more discussion and a proposed alternative patch.) BUG=700031 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Use highp for glCopyTexture2D where available This fixes artifacts in copied textures caused by insufficient precision in "mediump" floats when used for sampling textures. On a Pixel XL, a mediump only has 10 bits precision in fragment shaders, that apparently only works fully for texture dimensions < 1024 pixels. Use "highp" if both GL_ES and GL_FRAGMENT_PRECISION_HIGH are set for the shader. (See the bug for more discussion and a proposed alternative patch.) BUG=700031 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2744793002 Cr-Commit-Position: refs/heads/master@{#456012} Committed: https://chromium.googlesource.com/chromium/src/+/72efd11d727f12bc45e74a1e6f7e... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/72efd11d727f12bc45e74a1e6f7e... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
