Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 2744643002: Physical Web toggle should render as Off with pref in Default state (Closed)

Created:
3 years, 9 months ago by mmocny
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

Physical Web toggle should render as Off with pref in Default state Previously, the Physical Web toggle would render in the On position if the preference was still in the Default state and Chrome was authorized to use Location. Now, the preference will only render as On if the preference has been enabled. BUG=698392 Review-Url: https://codereview.chromium.org/2735463002 Cr-Commit-Position: refs/heads/master@{#454705} (cherry picked from commit 9c3ae5fc7b7a3a9395b882f80661f209f3bfc4ef) Review-Url: https://codereview.chromium.org/2744643002 . Cr-Commit-Position: refs/branch-heads/3029@{#84} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/cedf1e53b208a35c211dcf751f5272856f6f346b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M ios/chrome/browser/ui/settings/physical_web_collection_view_controller.mm View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
mmocny
3 years, 9 months ago (2017-03-09 15:55:58 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cedf1e53b208a35c211dcf751f5272856f6f346b (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698