Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2735463002: Physical Web toggle should render as Off with pref in Default state (Closed)

Created:
3 years, 9 months ago by mattreynolds
Modified:
3 years, 9 months ago
Reviewers:
lpromero
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Physical Web toggle should render as Off with pref in Default state Previously, the Physical Web toggle would render in the On position if the preference was still in the Default state and Chrome was authorized to use Location. Now, the preference will only render as On if the preference has been enabled. BUG=698392 Review-Url: https://codereview.chromium.org/2735463002 Cr-Commit-Position: refs/heads/master@{#454705} Committed: https://chromium.googlesource.com/chromium/src/+/9c3ae5fc7b7a3a9395b882f80661f209f3bfc4ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M ios/chrome/browser/ui/settings/physical_web_collection_view_controller.mm View 1 chunk +1 line, -8 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
mattreynolds
Hi Louis, PTAL
3 years, 9 months ago (2017-03-03 22:33:28 UTC) #2
lpromero
lgtm
3 years, 9 months ago (2017-03-03 22:41:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2735463002/1
3 years, 9 months ago (2017-03-03 22:41:53 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 23:17:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9c3ae5fc7b7a3a9395b882f80661...

Powered by Google App Engine
This is Rietveld 408576698