Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 2744553007: Upstream high resolution event timestamp tests to WPT (Closed)

Created:
3 years, 9 months ago by majidvp
Modified:
3 years, 5 months ago
Reviewers:
Rick Byers
CC:
chromium-reviews, blink-reviews, blink-reviews-w3ctests_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream high resolution event timestamp test to WPT. This is in anticipation of DOM spec patch landing [1]. Upstreaming two tests: - verify constructed events get a high-resolution time from perfomance.now() - verify the minimum resolution is larger that 5µs. [1] https://github.com/whatwg/dom/issues/23 [2] https://github.com/whatwg/dom/pull/420 BUG=538600 Review-Url: https://codereview.chromium.org/2744553007 Cr-Commit-Position: refs/heads/master@{#485966} Committed: https://chromium.googlesource.com/chromium/src/+/162c4ac09275ce579d43898be8f1fda4cbe07a32

Patch Set 1 #

Patch Set 2 : Upstream high resolution event timestamp tests to WPT #

Patch Set 3 : Make WPT lint happy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -41 lines) Patch
A + third_party/WebKit/LayoutTests/external/wpt/dom/events/Event-timestamp-high-resolution.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/dom/events/Event-timestamp-safe-resolution.html View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/hr-timestamp/constructed-events.html View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/events/hr-timestamp/safe-resolution.html View 1 chunk +0 lines, -20 lines 0 comments Download

Messages

Total messages: 30 (20 generated)
majidvp
3 years, 9 months ago (2017-03-10 14:26:32 UTC) #5
Rick Byers
LGTM annevk@ might want to review the tests as part of reviewing the spec change, ...
3 years, 9 months ago (2017-03-27 21:27:16 UTC) #8
majidvp
On 2017/03/27 21:27:16, Rick Byers wrote: > LGTM > > annevk@ might want to review ...
3 years, 5 months ago (2017-07-12 12:44:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744553007/20001
3 years, 5 months ago (2017-07-12 12:46:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744553007/20001
3 years, 5 months ago (2017-07-12 12:47:25 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/487045)
3 years, 5 months ago (2017-07-12 12:59:13 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744553007/40001
3 years, 5 months ago (2017-07-12 13:31:56 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/468448)
3 years, 5 months ago (2017-07-12 13:40:43 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744553007/40001
3 years, 5 months ago (2017-07-12 14:10:53 UTC) #26
commit-bot: I haz the power
3 years, 5 months ago (2017-07-12 15:38:51 UTC) #30
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/162c4ac09275ce579d43898be8f1...

Powered by Google App Engine
This is Rietveld 408576698