|
|
Created:
3 years, 9 months ago by majidvp Modified:
3 years, 5 months ago Reviewers:
Rick Byers CC:
chromium-reviews, blink-reviews, blink-reviews-w3ctests_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionUpstream high resolution event timestamp test to WPT.
This is in anticipation of DOM spec patch landing [1].
Upstreaming two tests:
- verify constructed events get a high-resolution time from perfomance.now()
- verify the minimum resolution is larger that 5µs.
[1] https://github.com/whatwg/dom/issues/23
[2] https://github.com/whatwg/dom/pull/420
BUG=538600
Review-Url: https://codereview.chromium.org/2744553007
Cr-Commit-Position: refs/heads/master@{#485966}
Committed: https://chromium.googlesource.com/chromium/src/+/162c4ac09275ce579d43898be8f1fda4cbe07a32
Patch Set 1 #Patch Set 2 : Upstream high resolution event timestamp tests to WPT #Patch Set 3 : Make WPT lint happy #
Messages
Total messages: 30 (20 generated)
The CQ bit was checked by majidvp@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Upstream high resolution event timestamp test to WPT. *IMPORTANT* Do NOT land until the pull request against spec is merged. This is in anticipation of resolving DOM spec landing [1]. Upstreaming two tests: - verify constructed events get a high-resolution time from perfomance.now() - verify the minimum resolution is larger that 5µs. [1] https://github.com/whatwg/dom/issues/23 [2] https://github.com/whatwg/dom/pull/420 BUG= ========== to ========== Upstream high resolution event timestamp test to WPT. *IMPORTANT* Do NOT land until the pull request against spec is merged. This is in anticipation of resolving DOM spec landing [1]. Upstreaming two tests: - verify constructed events get a high-resolution time from perfomance.now() - verify the minimum resolution is larger that 5µs. [1] https://github.com/whatwg/dom/issues/23 [2] https://github.com/whatwg/dom/pull/420 BUG= ==========
majidvp@chromium.org changed reviewers: + rbyers@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM annevk@ might want to review the tests as part of reviewing the spec change, not sure. In that case you can either point him here, or create a PR upstream in GitHub and after that lands, land the blink change to remove our LayoutTest copy (the latter is what HTML editors are used to doing, the former is a little less work for you of course).
On 2017/03/27 21:27:16, Rick Byers wrote: > LGTM > > annevk@ might want to review the tests as part of reviewing the spec change, not > sure. In that case you can either point him here, or create a PR upstream in > GitHub and after that lands, land the blink change to remove our LayoutTest copy > (the latter is what HTML editors are used to doing, the former is a little less > work for you of course). Spec change is now good. I believe annevk@ have looked at the tests as well. So landing this now and happy to change them if there is an issue found later.
Description was changed from ========== Upstream high resolution event timestamp test to WPT. *IMPORTANT* Do NOT land until the pull request against spec is merged. This is in anticipation of resolving DOM spec landing [1]. Upstreaming two tests: - verify constructed events get a high-resolution time from perfomance.now() - verify the minimum resolution is larger that 5µs. [1] https://github.com/whatwg/dom/issues/23 [2] https://github.com/whatwg/dom/pull/420 BUG= ========== to ========== Upstream high resolution event timestamp test to WPT. This is in anticipation of resolving DOM spec landing [1]. Upstreaming two tests: - verify constructed events get a high-resolution time from perfomance.now() - verify the minimum resolution is larger that 5µs. [1] https://github.com/whatwg/dom/issues/23 [2] https://github.com/whatwg/dom/pull/420 BUG= ==========
The CQ bit was checked by majidvp@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by majidvp@chromium.org
Description was changed from ========== Upstream high resolution event timestamp test to WPT. This is in anticipation of resolving DOM spec landing [1]. Upstreaming two tests: - verify constructed events get a high-resolution time from perfomance.now() - verify the minimum resolution is larger that 5µs. [1] https://github.com/whatwg/dom/issues/23 [2] https://github.com/whatwg/dom/pull/420 BUG= ========== to ========== Upstream high resolution event timestamp test to WPT. This is in anticipation of DOM spec patch landing [1]. Upstreaming two tests: - verify constructed events get a high-resolution time from perfomance.now() - verify the minimum resolution is larger that 5µs. [1] https://github.com/whatwg/dom/issues/23 [2] https://github.com/whatwg/dom/pull/420 BUG= ==========
The CQ bit was checked by majidvp@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Upstream high resolution event timestamp test to WPT. This is in anticipation of DOM spec patch landing [1]. Upstreaming two tests: - verify constructed events get a high-resolution time from perfomance.now() - verify the minimum resolution is larger that 5µs. [1] https://github.com/whatwg/dom/issues/23 [2] https://github.com/whatwg/dom/pull/420 BUG= ========== to ========== Upstream high resolution event timestamp test to WPT. This is in anticipation of DOM spec patch landing [1]. Upstreaming two tests: - verify constructed events get a high-resolution time from perfomance.now() - verify the minimum resolution is larger that 5µs. [1] https://github.com/whatwg/dom/issues/23 [2] https://github.com/whatwg/dom/pull/420 BUG=538600 ==========
The CQ bit was checked by majidvp@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rbyers@chromium.org Link to the patchset: https://codereview.chromium.org/2744553007/#ps40001 (title: "Make WPT lint happy")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by majidvp@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499868648933390, "parent_rev": "8cf5716792a541d83bd51c901b839a8fe9f8e834", "commit_rev": "91020a40c54a54731423b95434cc3fd1498ef7b5"}
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499868648933390, "parent_rev": "b3afb75bbf4bc8f13647ba4f260cf382219cedf1", "commit_rev": "162c4ac09275ce579d43898be8f1fda4cbe07a32"}
Message was sent while issue was closed.
Description was changed from ========== Upstream high resolution event timestamp test to WPT. This is in anticipation of DOM spec patch landing [1]. Upstreaming two tests: - verify constructed events get a high-resolution time from perfomance.now() - verify the minimum resolution is larger that 5µs. [1] https://github.com/whatwg/dom/issues/23 [2] https://github.com/whatwg/dom/pull/420 BUG=538600 ========== to ========== Upstream high resolution event timestamp test to WPT. This is in anticipation of DOM spec patch landing [1]. Upstreaming two tests: - verify constructed events get a high-resolution time from perfomance.now() - verify the minimum resolution is larger that 5µs. [1] https://github.com/whatwg/dom/issues/23 [2] https://github.com/whatwg/dom/pull/420 BUG=538600 Review-Url: https://codereview.chromium.org/2744553007 Cr-Commit-Position: refs/heads/master@{#485966} Committed: https://chromium.googlesource.com/chromium/src/+/162c4ac09275ce579d43898be8f1... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/162c4ac09275ce579d43898be8f1... |