Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2744553005: [Offline Pages] Turn Offliner::Cancel into an async operation to resolve conflicting assumptions be… (Closed)

Created:
3 years, 9 months ago by Dmitry Titov
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Turn Offliner::Cancel into an async operation to resolve conflicting assumptions between the Offliner and RequestCoordinator. Upon Offliner::Cancel, RequestCoordinator assumes that the offliner is free, but offliner may be waiting until save operation to complete. This discrepancy causes RequestCoordinator to bombard the offliner with all the pending requests, potentially blocking the main thread for the save operation callback to be called and causing all pending requests to be labeled as EXPIRED BUG=694864 Review-Url: https://codereview.chromium.org/2715433006 Cr-Commit-Position: refs/heads/master@{#454740} (cherry picked from commit 9f04f39d54f599a346c59670f91923f4af05e416) Review-Url: https://codereview.chromium.org/2744553005 . Cr-Commit-Position: refs/branch-heads/3029@{#105} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/dedea73d3b658d752873cadbc162c84f88bcd878

Patch Set 1 #

Messages

Total messages: 2 (1 generated)
Dmitry Titov
3 years, 9 months ago (2017-03-10 01:25:30 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dedea73d3b658d752873cadbc162c84f88bcd878.

Powered by Google App Engine
This is Rietveld 408576698