Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3325)

Unified Diff: chrome/browser/android/offline_pages/prerendering_offliner.h

Issue 2744553005: [Offline Pages] Turn Offliner::Cancel into an async operation to resolve conflicting assumptions be… (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/prerendering_offliner.h
diff --git a/chrome/browser/android/offline_pages/prerendering_offliner.h b/chrome/browser/android/offline_pages/prerendering_offliner.h
index 18f637acdc0cbb6a640b9d38957c4842ca9974d7..71c1a93a19abe9792878738750613f436292fcf2 100644
--- a/chrome/browser/android/offline_pages/prerendering_offliner.h
+++ b/chrome/browser/android/offline_pages/prerendering_offliner.h
@@ -37,7 +37,7 @@ class PrerenderingOffliner : public Offliner {
bool LoadAndSave(const SavePageRequest& request,
const CompletionCallback& completion_callback,
const ProgressCallback& progress_callback) override;
- void Cancel() override;
+ void Cancel(const CancelCallback& callback) override;
bool HandleTimeout(const SavePageRequest& request) override;
// Allows a loader to be injected for testing. This may only be done once
@@ -77,6 +77,8 @@ class PrerenderingOffliner : public Offliner {
// Listener function for changes to application background/foreground state.
void OnApplicationStateChange(
base::android::ApplicationState application_state);
+ void HandleApplicationStateChangeCancel(const SavePageRequest& request,
+ int64_t offline_id);
// Not owned.
content::BrowserContext* browser_context_;

Powered by Google App Engine
This is Rietveld 408576698