[string] Refactor direct string conversions

[string] Refactor direct string conversions

This unifies several of the places in CSA that convert various
string kinds (cons, thin, sliced) to direct strings 
(sequential, external).

A couple of spots remain with duplicate code, but most of these are
more difficult to unify due to specific optimizations.

BUG=

Review-Url: https://codereview.chromium.org/2744263002
Cr-Commit-Position: refs/heads/master@{#43848}
Committed: https://chromium.googlesource.com/v8/v8/+/460ba9c22405d839a642eb2ba799ab2bcc611940

[jgruber, 2017-03-13 13:21:33]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 13:21:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 13:51:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 13:51:08]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-03-13 14:15:27]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-13 14:15:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 14:37:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 14:37:57]

Dry run: This issue passed the CQ dry run.

[jgruber, 2017-03-13 14:41:50]

Description was changed from

==========
[string] Refactor direct string conversions

BUG=
==========

to

==========
[string] Refactor direct string conversions

This unifies several of the places in CSA that convert various
string kinds (cons, thin, sliced) to direct strings 
(sequential, external).

A couple of spots remain with duplicate code, but most of these are
more difficult to unify due to specific optimizations.

BUG=
==========

[jgruber, 2017-03-13 14:42:13]

jgruber@chromium.org changed reviewers:
+ cbruni@chromium.org, ishell@chromium.org

[Camillo Bruni, 2017-03-14 09:06:04]

lgtm

https://codereview.chromium.org/2744263002/diff/20001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2744263002/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.cc:3239: Node* const offset = SmiAdd(from,
SmiTag(to_direct.offset()));
Future refactoring: make offset an intptr, from what I see this could simplify
code a bit given the frequent SmiConstant(Smi::FromInt(..)) pattern.

[jgruber, 2017-03-16 08:21:33]

The CQ bit was checked by jgruber@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 08:21:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-03-16 08:44:37]

The CQ bit was checked by jgruber@chromium.org

[jgruber, 2017-03-16 08:44:38]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/2744263002/#ps60001
(title: "Tweaks")

[commit-bot: I haz the power, 2017-03-16 08:44:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jgruber, 2017-03-16 08:44:54]

https://codereview.chromium.org/2744263002/diff/20001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2744263002/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.cc:3239: Node* const offset = SmiAdd(from,
SmiTag(to_direct.offset()));
On 2017/03/14 09:06:04, Camillo Bruni wrote:
> Future refactoring: make offset an intptr, from what I see this could simplify
> code a bit given the frequent SmiConstant(Smi::FromInt(..)) pattern.

Acknowledged.

[commit-bot: I haz the power, 2017-03-16 09:09:41]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489653877377710,
"parent_rev": "9e827c23841fd24877481bae053e6f67f6ddc6f5", "commit_rev":
"460ba9c22405d839a642eb2ba799ab2bcc611940"}

[commit-bot: I haz the power, 2017-03-16 09:09:45]

Description was changed from

==========
[string] Refactor direct string conversions

This unifies several of the places in CSA that convert various
string kinds (cons, thin, sliced) to direct strings 
(sequential, external).

A couple of spots remain with duplicate code, but most of these are
more difficult to unify due to specific optimizations.

BUG=
==========

to

==========
[string] Refactor direct string conversions

This unifies several of the places in CSA that convert various
string kinds (cons, thin, sliced) to direct strings 
(sequential, external).

A couple of spots remain with duplicate code, but most of these are
more difficult to unify due to specific optimizations.

BUG=

Review-Url: https://codereview.chromium.org/2744263002
Cr-Commit-Position: refs/heads/master@{#43848}
Committed:
https://chromium.googlesource.com/v8/v8/+/460ba9c22405d839a642eb2ba799ab2bcc6...
==========

[commit-bot: I haz the power, 2017-03-16 09:09:46]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/460ba9c22405d839a642eb2ba799ab2bcc6...