Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: src/builtins/builtins-regexp.h

Issue 2744263002: [string] Refactor direct string conversions (Closed)
Patch Set: Tweaks Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/builtins/builtins-regexp.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins/builtins-regexp.h
diff --git a/src/builtins/builtins-regexp.h b/src/builtins/builtins-regexp.h
index b41d58786512ece32168c08268d08ed60cc0f750..3fde4e64752eebd11366cb180aa8750627f529ce 100644
--- a/src/builtins/builtins-regexp.h
+++ b/src/builtins/builtins-regexp.h
@@ -34,10 +34,10 @@ class RegExpBuiltinsAssembler : public CodeStubAssembler {
bool is_fastpath);
// Loads {var_string_start} and {var_string_end} with the corresponding
- // offsets into the given {string}.
- void GetStringPointers(Node* const string, Node* const offset,
+ // offsets into the given {string_data}.
+ void GetStringPointers(Node* const string_data, Node* const offset,
Node* const last_index, Node* const string_length,
- bool is_one_byte, Variable* var_string_start,
+ String::Encoding encoding, Variable* var_string_start,
Variable* var_string_end);
// Low level logic around the actual call into generated Irregexp code.
« no previous file with comments | « no previous file | src/builtins/builtins-regexp.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698