Wait until draw is defined in webrtc.webrtc_smoothness_tbmv2

Wait until draw is defined in webrtc.webrtc_smoothness_tbmv2

BUG=chromium:702201
R=sullivan@chromium.org, nednguyen@google.com

Review-Url: https://codereview.chromium.org/2744243007
Cr-Commit-Position: refs/heads/master@{#457734}
Committed: https://chromium.googlesource.com/chromium/src/+/3048e3edc722ebe3a7db5643d0e1585b372271f7

[ehmaldonado_chromium, 2017-03-16 15:39:18]

What do you think?
How do I know if this would fix the issue?

[nednguyen, 2017-03-16 16:01:48]

On 2017/03/16 15:39:18, ehmaldonado_chromium wrote:
> What do you think?
> How do I know if this would fix the issue?

Can you run the benchmark on your mobile to test?

[ehmaldonado_chromium, 2017-03-16 16:04:43]

On 2017/03/16 16:01:48, nednguyen wrote:
> On 2017/03/16 15:39:18, ehmaldonado_chromium wrote:
> > What do you think?
> > How do I know if this would fix the issue?
> 
> Can you run the benchmark on your mobile to test?

I couldn't reproduce it locally in the first place.

[nednguyen, 2017-03-16 16:12:35]

https://codereview.chromium.org/2744243007/diff/1/tools/perf/page_sets/webrtc...
File tools/perf/page_sets/webrtc_cases.py (right):

https://codereview.chromium.org/2744243007/diff/1/tools/perf/page_sets/webrtc...
tools/perf/page_sets/webrtc_cases.py:152: action_runner.Wait(10)
Please wait for until the draw command is defined instead. Don't just add 10s
wait like this because it bumps up the timing across all the machines.

[ehmaldonado_chromium, 2017-03-16 17:04:08]

Description was changed from

==========
Wait 10s before calling draw in webrtc.webrtc_smoothness_tbmv2

Hopefully this is enough.

BUG=chromium:702201
R=sullivan@chromium.org, nednguyen@google.com
==========

to

==========
Wait until draw is defined in webrtc.webrtc_smoothness_tbmv2

BUG=chromium:702201
R=sullivan@chromium.org, nednguyen@google.com
==========

[ehmaldonado_chromium, 2017-03-16 17:04:44]

On 2017/03/16 16:12:35, nednguyen wrote:
>
https://codereview.chromium.org/2744243007/diff/1/tools/perf/page_sets/webrtc...
> File tools/perf/page_sets/webrtc_cases.py (right):
> 
>
https://codereview.chromium.org/2744243007/diff/1/tools/perf/page_sets/webrtc...
> tools/perf/page_sets/webrtc_cases.py:152: action_runner.Wait(10)
> Please wait for until the draw command is defined instead. Don't just add 10s
> wait like this because it bumps up the timing across all the machines.

Done. PTAL.

[nednguyen, 2017-03-16 19:16:45]

On 2017/03/16 17:04:44, ehmaldonado_chromium wrote:
> On 2017/03/16 16:12:35, nednguyen wrote:
> >
>
https://codereview.chromium.org/2744243007/diff/1/tools/perf/page_sets/webrtc...
> > File tools/perf/page_sets/webrtc_cases.py (right):
> > 
> >
>
https://codereview.chromium.org/2744243007/diff/1/tools/perf/page_sets/webrtc...
> > tools/perf/page_sets/webrtc_cases.py:152: action_runner.Wait(10)
> > Please wait for until the draw command is defined instead. Don't just add
10s
> > wait like this because it bumps up the timing across all the machines.
> 
> Done. PTAL.

Lgtm

[ehmaldonado_chromium, 2017-03-17 10:20:53]

The CQ bit was checked by ehmaldonado@chromium.org

[commit-bot: I haz the power, 2017-03-17 10:21:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 11:16:55]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489746053122500,
"parent_rev": "8bc3403788ff7fcfa1036878c544ceb7fedf1da4", "commit_rev":
"3048e3edc722ebe3a7db5643d0e1585b372271f7"}

[commit-bot: I haz the power, 2017-03-17 11:17:37]

Description was changed from

==========
Wait until draw is defined in webrtc.webrtc_smoothness_tbmv2

BUG=chromium:702201
R=sullivan@chromium.org, nednguyen@google.com
==========

to

==========
Wait until draw is defined in webrtc.webrtc_smoothness_tbmv2

BUG=chromium:702201
R=sullivan@chromium.org, nednguyen@google.com

Review-Url: https://codereview.chromium.org/2744243007
Cr-Commit-Position: refs/heads/master@{#457734}
Committed:
https://chromium.googlesource.com/chromium/src/+/3048e3edc722ebe3a7db5643d0e1...
==========

[commit-bot: I haz the power, 2017-03-17 11:17:38]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3048e3edc722ebe3a7db5643d0e1...

[ehmaldonado_chromium, 2017-03-20 10:13:57]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2758263002/ by ehmaldonado@chromium.org.

The reason for reverting is: Now we're running into HTTPS issues:
https://console.developers.google.com/m/cloudstorage/b/chrome-telemetry-outpu....