Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Side by Side Diff: tools/perf/benchmarks/webrtc.py

Issue 2744243007: Wait until draw is defined in webrtc.webrtc_smoothness_tbmv2 (Closed)
Patch Set: Wait until draw becomes defined. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | tools/perf/page_sets/webrtc_cases.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from core import perf_benchmark 5 from core import perf_benchmark
6 6
7 from measurements import webrtc 7 from measurements import webrtc
8 import page_sets 8 import page_sets
9 from telemetry import benchmark 9 from telemetry import benchmark
10 from telemetry.timeline import chrome_trace_category_filter 10 from telemetry.timeline import chrome_trace_category_filter
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 options.AppendExtraBrowserArgs('--use-fake-device-for-media-stream') 91 options.AppendExtraBrowserArgs('--use-fake-device-for-media-stream')
92 options.AppendExtraBrowserArgs('--use-fake-ui-for-media-stream') 92 options.AppendExtraBrowserArgs('--use-fake-ui-for-media-stream')
93 93
94 @classmethod 94 @classmethod
95 def Name(cls): 95 def Name(cls):
96 return 'webrtc.webrtc_smoothness' 96 return 'webrtc.webrtc_smoothness'
97 97
98 98
99 # WebrtcRenderingTBMv2 must be a PerfBenchmark, and not a _Webrtc, because it is 99 # WebrtcRenderingTBMv2 must be a PerfBenchmark, and not a _Webrtc, because it is
100 # a timeline-based metric. 100 # a timeline-based metric.
101 @benchmark.Disabled('android') # crbug.com/702201
102 @benchmark.Owner(emails=['ehmaldonado@chromium.org', 101 @benchmark.Owner(emails=['ehmaldonado@chromium.org',
103 'phoglund@chromium.org', 102 'phoglund@chromium.org',
104 'qiangchen@chromium.org']) 103 'qiangchen@chromium.org'])
105 class WebrtcRenderingTBMv2(perf_benchmark.PerfBenchmark): 104 class WebrtcRenderingTBMv2(perf_benchmark.PerfBenchmark):
106 """Specific time measurements (e.g. fps, smoothness) for WebRtc rendering.""" 105 """Specific time measurements (e.g. fps, smoothness) for WebRtc rendering."""
107 106
108 page_set = page_sets.WebrtcRenderingPageSet 107 page_set = page_sets.WebrtcRenderingPageSet
109 108
110 def CreateTimelineBasedMeasurementOptions(self): 109 def CreateTimelineBasedMeasurementOptions(self):
111 category_filter = chrome_trace_category_filter.ChromeTraceCategoryFilter( 110 category_filter = chrome_trace_category_filter.ChromeTraceCategoryFilter(
112 filter_string='webrtc,toplevel') 111 filter_string='webrtc,toplevel')
113 options = timeline_based_measurement.Options(category_filter) 112 options = timeline_based_measurement.Options(category_filter)
114 options.SetTimelineBasedMetrics([ 113 options.SetTimelineBasedMetrics([
115 'cpuTimeMetric', 114 'cpuTimeMetric',
116 'expectedQueueingTimeMetric', 115 'expectedQueueingTimeMetric',
117 'webrtcRenderingMetric', 116 'webrtcRenderingMetric',
118 ]) 117 ])
119 return options 118 return options
120 119
121 def SetExtraBrowserOptions(self, options): 120 def SetExtraBrowserOptions(self, options):
122 options.AppendExtraBrowserArgs('--use-fake-device-for-media-stream') 121 options.AppendExtraBrowserArgs('--use-fake-device-for-media-stream')
123 options.AppendExtraBrowserArgs('--use-fake-ui-for-media-stream') 122 options.AppendExtraBrowserArgs('--use-fake-ui-for-media-stream')
124 123
125 @classmethod 124 @classmethod
126 def Name(cls): 125 def Name(cls):
127 return 'webrtc.webrtc_smoothness_tbmv2' 126 return 'webrtc.webrtc_smoothness_tbmv2'
OLDNEW
« no previous file with comments | « no previous file | tools/perf/page_sets/webrtc_cases.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698