Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 2744103002: Remove DCHECKs in TypedElementsAccessor (Closed)

Created:
3 years, 9 months ago by Choongwoo Han
Modified:
3 years, 9 months ago
Reviewers:
caitp, Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove DCHECKs in TypedElementsAccessor Since typedarrays are integer indexed exotic objects, we don't need to check if prototypes of a typedarray have elements or not. https://tc39.github.io/ecma262/#sec-integer-indexed-exotic-objects-get-p-receiver BUG=699020 Review-Url: https://codereview.chromium.org/2744103002 Cr-Commit-Position: refs/heads/master@{#43738} Committed: https://chromium.googlesource.com/v8/v8/+/4aeb26579993622ff374cb21dbfcfa2ba2d673d8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M src/elements.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Choongwoo Han
PTAL
3 years, 9 months ago (2017-03-11 10:37:40 UTC) #3
Camillo Bruni
lgtm
3 years, 9 months ago (2017-03-13 07:58:01 UTC) #6
Camillo Bruni
Thanks! note: I added the link to the spec text
3 years, 9 months ago (2017-03-13 07:58:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2744103002/1
3 years, 9 months ago (2017-03-13 08:17:13 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 08:38:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/4aeb26579993622ff374cb21dbfcfa2ba2d...

Powered by Google App Engine
This is Rietveld 408576698