Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Unified Diff: src/elements.cc

Issue 2744103002: Remove DCHECKs in TypedElementsAccessor (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/elements.cc
diff --git a/src/elements.cc b/src/elements.cc
index 7b7f6893d84b557224acb1232b7798eb39cbb461..7a12f6606516f78d8ae0a7bffbd54654b0cd84c7 100644
--- a/src/elements.cc
+++ b/src/elements.cc
@@ -2819,7 +2819,6 @@ class TypedElementsAccessor
Handle<JSObject> receiver,
Handle<Object> value,
uint32_t start_from, uint32_t length) {
- DCHECK(JSObject::PrototypeHasNoElements(isolate, *receiver));
DisallowHeapAllocation no_gc;
// TODO(caitp): return Just(false) here when implementing strict throwing on
@@ -2874,7 +2873,6 @@ class TypedElementsAccessor
Handle<JSObject> receiver,
Handle<Object> value,
uint32_t start_from, uint32_t length) {
- DCHECK(JSObject::PrototypeHasNoElements(isolate, *receiver));
DisallowHeapAllocation no_gc;
if (WasNeutered(*receiver)) return Just<int64_t>(-1);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698