Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2743993003: cocoa: add experimental tabstrip keyboard focus support (Closed)

Created:
3 years, 9 months ago by Elly Fong-Jones
Modified:
3 years, 9 months ago
CC:
chromium-reviews, srahim+watch_chromium.org, mac-reviews_chromium.org, asvitkine+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cocoa: add experimental tabstrip keyboard focus support This change: 1) Adds a feature named TabStripKeyboardFocus, 2) Adds a corresponding flag in chrome://flags, 3) Adds support for tabs to become first responders, 4) Adds support for tabs to draw focus rings, 5) Adds support for pressing Enter on a focused tab to switch to it BUG=696269 Review-Url: https://codereview.chromium.org/2743993003 Cr-Commit-Position: refs/heads/master@{#456476} Committed: https://chromium.googlesource.com/chromium/src/+/36389d38b27507d25f4c3f2edc66933b5a96b262

Patch Set 1 #

Patch Set 2 : fix histogram #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_controller.mm View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_view.mm View 4 chunks +27 lines, -0 lines 0 comments Download
M chrome/common/chrome_features.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_features.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
Elly Fong-Jones
mark: ptal? :)
3 years, 9 months ago (2017-03-10 20:14:57 UTC) #3
Mark Mentovai
LGTM
3 years, 9 months ago (2017-03-10 21:19:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743993003/1
3 years, 9 months ago (2017-03-13 13:21:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/405430)
3 years, 9 months ago (2017-03-13 14:10:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743993003/20001
3 years, 9 months ago (2017-03-13 15:32:27 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/383912)
3 years, 9 months ago (2017-03-13 15:40:02 UTC) #13
Elly Fong-Jones
isherman: ptal as //tools/metrics/histograms owner?
3 years, 9 months ago (2017-03-13 16:01:30 UTC) #15
Ilya Sherman
histograms.xml lgtm
3 years, 9 months ago (2017-03-13 18:57:52 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743993003/20001
3 years, 9 months ago (2017-03-13 20:11:56 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 20:56:48 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/36389d38b27507d25f4c3f2edc66...

Powered by Google App Engine
This is Rietveld 408576698