cocoa: add experimental tabstrip keyboard focus support

cocoa: add experimental tabstrip keyboard focus support

This change:
1) Adds a feature named TabStripKeyboardFocus,
2) Adds a corresponding flag in chrome://flags,
3) Adds support for tabs to become first responders,
4) Adds support for tabs to draw focus rings,
5) Adds support for pressing Enter on a focused tab to switch to it

BUG=696269
Review-Url: https://codereview.chromium.org/2743993003
Cr-Commit-Position: refs/heads/master@{#456476}
Committed: https://chromium.googlesource.com/chromium/src/+/36389d38b27507d25f4c3f2edc66933b5a96b262

[Elly Fong-Jones, 2017-03-10 20:14:50]

Description was changed from

==========
cocoa: add experimental tabstrip keyboard focus support

This change:
1) Adds a feature named TabStripKeyboardFocus,
2) Adds a corresponding flag in chrome://flags,
3) Adds support for tabs to become first responders,
4) Adds support for tabs to draw focus rings,
5) Adds support for pressing Enter on a focused tab to switch to it

BUG=696269
==========

to

==========
cocoa: add experimental tabstrip keyboard focus support

This change:
1) Adds a feature named TabStripKeyboardFocus,
2) Adds a corresponding flag in chrome://flags,
3) Adds support for tabs to become first responders,
4) Adds support for tabs to draw focus rings,
5) Adds support for pressing Enter on a focused tab to switch to it

BUG=696269
==========

[Elly Fong-Jones, 2017-03-10 20:14:50]

ellyjones@chromium.org changed reviewers:
+ mark@chromium.org

[Elly Fong-Jones, 2017-03-10 20:14:57]

mark: ptal? :)

[Mark Mentovai, 2017-03-10 21:19:53]

LGTM

[Elly Fong-Jones, 2017-03-13 13:20:53]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2017-03-13 13:21:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 14:10:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 14:10:02]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Elly Fong-Jones, 2017-03-13 15:32:00]

The CQ bit was checked by ellyjones@chromium.org

[Elly Fong-Jones, 2017-03-13 15:32:00]

The patchset sent to the CQ was uploaded after l-g-t-m from mark@chromium.org
Link to the patchset: https://codereview.chromium.org/2743993003/#ps20001
(title: "fix histogram")

[commit-bot: I haz the power, 2017-03-13 15:32:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 15:40:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 15:40:02]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Elly Fong-Jones, 2017-03-13 16:01:18]

ellyjones@chromium.org changed reviewers:
+ isherman@chromium.org

[Elly Fong-Jones, 2017-03-13 16:01:30]

isherman: ptal as //tools/metrics/histograms owner?

[Ilya Sherman, 2017-03-13 18:57:52]

histograms.xml lgtm

[Elly Fong-Jones, 2017-03-13 20:11:30]

The CQ bit was checked by ellyjones@chromium.org

[commit-bot: I haz the power, 2017-03-13 20:11:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 20:56:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489435890119630,
"parent_rev": "d1e696f750284979a012124a04fde37b19032e89", "commit_rev":
"36389d38b27507d25f4c3f2edc66933b5a96b262"}

[commit-bot: I haz the power, 2017-03-13 20:56:47]

Description was changed from

==========
cocoa: add experimental tabstrip keyboard focus support

This change:
1) Adds a feature named TabStripKeyboardFocus,
2) Adds a corresponding flag in chrome://flags,
3) Adds support for tabs to become first responders,
4) Adds support for tabs to draw focus rings,
5) Adds support for pressing Enter on a focused tab to switch to it

BUG=696269
==========

to

==========
cocoa: add experimental tabstrip keyboard focus support

This change:
1) Adds a feature named TabStripKeyboardFocus,
2) Adds a corresponding flag in chrome://flags,
3) Adds support for tabs to become first responders,
4) Adds support for tabs to draw focus rings,
5) Adds support for pressing Enter on a focused tab to switch to it

BUG=696269

Review-Url: https://codereview.chromium.org/2743993003
Cr-Commit-Position: refs/heads/master@{#456476}
Committed:
https://chromium.googlesource.com/chromium/src/+/36389d38b27507d25f4c3f2edc66...
==========

[commit-bot: I haz the power, 2017-03-13 20:56:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/36389d38b27507d25f4c3f2edc66...