Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2743993003: cocoa: add experimental tabstrip keyboard focus support (Closed)
Patch Set: fix histogram Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/cocoa/tabs/tab_controller.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 2331 matching lines...) Expand 10 before | Expand all | Expand 10 after
2342 FEATURE_VALUE_TYPE(chrome::android::kCustomFeedbackUi)}, 2342 FEATURE_VALUE_TYPE(chrome::android::kCustomFeedbackUi)},
2343 #endif // OS_ANDROID 2343 #endif // OS_ANDROID
2344 2344
2345 {"enable-resource-prefetch", IDS_FLAGS_SPECULATIVE_PREFETCH_NAME, 2345 {"enable-resource-prefetch", IDS_FLAGS_SPECULATIVE_PREFETCH_NAME,
2346 IDS_FLAGS_SPECULATIVE_PREFETCH_DESCRIPTION, kOsAll, 2346 IDS_FLAGS_SPECULATIVE_PREFETCH_DESCRIPTION, kOsAll,
2347 FEATURE_WITH_VARIATIONS_VALUE_TYPE( 2347 FEATURE_WITH_VARIATIONS_VALUE_TYPE(
2348 predictors::kSpeculativeResourcePrefetchingFeature, 2348 predictors::kSpeculativeResourcePrefetchingFeature,
2349 kSpeculativeResourcePrefetchingFeatureVariations, 2349 kSpeculativeResourcePrefetchingFeatureVariations,
2350 "SpeculativeResourcePrefetchingValidation")}, 2350 "SpeculativeResourcePrefetchingValidation")},
2351 2351
2352 #if defined(OS_MACOSX)
2353 {"tab-strip-keyboard-focus", IDS_FLAGS_TAB_STRIP_KEYBOARD_FOCUS_NAME,
2354 IDS_FLAGS_TAB_STRIP_KEYBOARD_FOCUS_DESCRIPTION, kOsMac,
2355 FEATURE_VALUE_TYPE(features::kTabStripKeyboardFocus)}
2356 #endif
2357
2352 // NOTE: Adding new command-line switches requires adding corresponding 2358 // NOTE: Adding new command-line switches requires adding corresponding
2353 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 2359 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
2354 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 2360 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
2355 }; 2361 };
2356 2362
2357 class FlagsStateSingleton { 2363 class FlagsStateSingleton {
2358 public: 2364 public:
2359 FlagsStateSingleton() 2365 FlagsStateSingleton()
2360 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {} 2366 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {}
2361 ~FlagsStateSingleton() {} 2367 ~FlagsStateSingleton() {}
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
2550 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2556 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2551 2557
2552 const FeatureEntry* GetFeatureEntries(size_t* count) { 2558 const FeatureEntry* GetFeatureEntries(size_t* count) {
2553 *count = arraysize(kFeatureEntries); 2559 *count = arraysize(kFeatureEntries);
2554 return kFeatureEntries; 2560 return kFeatureEntries;
2555 } 2561 }
2556 2562
2557 } // namespace testing 2563 } // namespace testing
2558 2564
2559 } // namespace about_flags 2565 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/ui/cocoa/tabs/tab_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698