Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2743863002:
MD Settings: fix toggle button spacing (Closed)
|
Created:
3 years, 9 months ago by Dan Beam Modified:
3 years, 9 months ago CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMD Settings: fix toggle button spacing
R=scottchen@chromium.org
BUG=none (that I know of)
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2743863002
Cr-Commit-Position: refs/heads/master@{#456178}
Committed: https://chromium.googlesource.com/chromium/src/+/2e90a7a5c0009a95b5d602ee9a3632edea75afdb
Patch Set 1 #
Total comments: 4
Patch Set 2 : merge #
Total comments: 2
Messages
Total messages: 25 (12 generated)
Description was changed from ========== MD Settings: fix toggle button spacing R=scottchen@chromium.org BUG= ========== to ========== MD Settings: fix toggle button spacing R=scottchen@chromium.org BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
lgtm https://codereview.chromium.org/2743863002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/controls/settings_toggle_button.html (right): https://codereview.chromium.org/2743863002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/controls/settings_toggle_button.html:32: ::content .more-actions, that's cool, didn't know about ::content. https://codereview.chromium.org/2743863002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/controls/settings_toggle_button.html:40: hidden="[[!label]]"> would dom-if be better here?
https://codereview.chromium.org/2743863002/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/controls/settings_toggle_button.html (right): https://codereview.chromium.org/2743863002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/controls/settings_toggle_button.html:32: ::content .more-actions, On 2017/03/10 19:05:46, scottchen wrote: > that's cool, didn't know about ::content. it's probably going away soon, don't get used to it ;) https://codereview.chromium.org/2743863002/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/controls/settings_toggle_button.html:40: hidden="[[!label]]"> On 2017/03/10 19:05:46, scottchen wrote: > would dom-if be better here? for a couple <div>s, probably not
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
dpapad@chromium.org changed reviewers: + dpapad@chromium.org
Is this related to https://bugs.chromium.org/p/chromium/issues/detail?id=700342#c1 or some other bug? Let's add BUG=None if no issue exists. LGTM
On 2017/03/10 19:57:57, dpapad wrote: > Is this related to > https://bugs.chromium.org/p/chromium/issues/detail?id=700342#c1 or some other > bug? Let's add BUG=None if no issue exists. > > LGTM no, not related. toggles are just really far from divider lines in places like Autofill or Passwords (when used without a label)
Description was changed from ========== MD Settings: fix toggle button spacing R=scottchen@chromium.org BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: fix toggle button spacing R=scottchen@chromium.org BUG=none (that I know of) CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) closure_compilation on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by dbeam@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from scottchen@chromium.org, dpapad@chromium.org Link to the patchset: https://codereview.chromium.org/2743863002/#ps20001 (title: "merge")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489177097455910,
"parent_rev": "db0b85bc46d4602f7b275001f26cbf6052267d35", "commit_rev":
"2e90a7a5c0009a95b5d602ee9a3632edea75afdb"}
Message was sent while issue was closed.
Description was changed from ========== MD Settings: fix toggle button spacing R=scottchen@chromium.org BUG=none (that I know of) CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== MD Settings: fix toggle button spacing R=scottchen@chromium.org BUG=none (that I know of) CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2743863002 Cr-Commit-Position: refs/heads/master@{#456178} Committed: https://chromium.googlesource.com/chromium/src/+/2e90a7a5c0009a95b5d602ee9a36... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/2e90a7a5c0009a95b5d602ee9a36...
Message was sent while issue was closed.
stevenjb@chromium.org changed reviewers: + stevenjb@chromium.org
Message was sent while issue was closed.
https://codereview.chromium.org/2743863002/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/controls/settings_toggle_button.html (right): https://codereview.chromium.org/2743863002/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/controls/settings_toggle_button.html:35: } This appears to be incorrect: * .more-actions is no longer separated from the toggle button when there is no pref indicator. * The label is now indented differently from other controls. * the indicator and toggle are now very close together. Was this supposed to be -webkit-margin-end? It looks like that would fix everything.
Message was sent while issue was closed.
On 2017/03/14 at 20:56:39, stevenjb wrote: > https://codereview.chromium.org/2743863002/diff/20001/chrome/browser/resource... > File chrome/browser/resources/settings/controls/settings_toggle_button.html (right): > > https://codereview.chromium.org/2743863002/diff/20001/chrome/browser/resource... > chrome/browser/resources/settings/controls/settings_toggle_button.html:35: } > This appears to be incorrect: > * .more-actions is no longer separated from the toggle button when there is no pref indicator. > * The label is now indented differently from other controls. > * the indicator and toggle are now very close together. > > Was this supposed to be -webkit-margin-end? It looks like that would fix everything. Fixed already by @dbeam in a follow up, https://codereview.chromium.org/2751533002.
Message was sent while issue was closed.
https://codereview.chromium.org/2743863002/diff/20001/chrome/browser/resource... File chrome/browser/resources/settings/controls/settings_toggle_button.html (right): https://codereview.chromium.org/2743863002/diff/20001/chrome/browser/resource... chrome/browser/resources/settings/controls/settings_toggle_button.html:35: } On 2017/03/14 20:56:39, stevenjb wrote: > This appears to be incorrect: > * .more-actions is no longer separated from the toggle button when there is no > pref indicator. > * The label is now indented differently from other controls. > * the indicator and toggle are now very close together. > > Was this supposed to be -webkit-margin-end? It looks like that would fix > everything. yup, was a merge conflict: https://codereview.chromium.org/2743863002/diff2/1:20001/chrome/browser/resou... |
