Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2751533002: MD Settings: fix <settings-toggle-button> indent issue (Closed)

Created:
3 years, 9 months ago by Dan Beam
Modified:
3 years, 9 months ago
Reviewers:
dpapad
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: fix <settings-toggle-button> indent issue I accidentally switched to -start margin instead of -end because of a merge conflict between these patch sets: https://codereview.chromium.org/2743863002/diff2/1:20001/chrome/browser/resources/settings/controls/settings_toggle_button.html R=dpapad@chromium.org BUG=none (yet) CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2751533002 Cr-Commit-Position: refs/heads/master@{#456546} Committed: https://chromium.googlesource.com/chromium/src/+/ffcbf762962091fe257f480dec34781b5864b120

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/controls/settings_toggle_button.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Dan Beam
3 years, 9 months ago (2017-03-13 21:43:11 UTC) #2
dpapad
lgtm
3 years, 9 months ago (2017-03-13 21:49:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2751533002/1
3 years, 9 months ago (2017-03-13 22:00:53 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 23:40:05 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ffcbf762962091fe257f480dec34...

Powered by Google App Engine
This is Rietveld 408576698