Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 2743663005: [memory-infra] Add unittests for peak detection and NotifyDumpTriggered (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 2 weeks ago by ssid
Modified:
2 months, 1 week ago
Reviewers:
Primiano Tucci, dcheng
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[memory-infra] Add unittests for peak detection and NotifyDumpTriggered BUG=607533

Patch Set 1 #

Patch Set 2 : . #

Total comments: 6

Patch Set 3 : Remove unused include #

Patch Set 4 : get back include #

Patch Set 5 : get back include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -2 lines) Patch
M base/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M base/trace_event/memory_dump_scheduler.h View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
A base/trace_event/memory_dump_scheduler_unittest.cc View 1 3 1 chunk +95 lines, -0 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 46 (26 generated)
ssid
Sorry for doing this late. I just realized test coverage isn't enough.
2 months, 2 weeks ago (2017-03-11 00:26:58 UTC) #6
ssid
On 2017/03/11 00:26:58, ssid wrote: > Sorry for doing this late. I just realized test ...
2 months, 2 weeks ago (2017-03-11 00:40:31 UTC) #7
Primiano Tucci
LGTM > Do you think I should move these tests to memory_dump_manager_unittest as well? Whatever ...
2 months, 1 week ago (2017-03-16 19:05:04 UTC) #8
ssid
+dcheng for one base/BUILD.gn file addition. ptal thanks!
2 months, 1 week ago (2017-03-20 23:26:04 UTC) #10
dcheng
rs lgtm https://codereview.chromium.org/2743663005/diff/60001/base/trace_event/memory_dump_scheduler_unittest.cc File base/trace_event/memory_dump_scheduler_unittest.cc (right): https://codereview.chromium.org/2743663005/diff/60001/base/trace_event/memory_dump_scheduler_unittest.cc#newcode9 base/trace_event/memory_dump_scheduler_unittest.cc:9: #include "base/single_thread_task_runner.h" Seems unused. https://codereview.chromium.org/2743663005/diff/60001/base/trace_event/memory_dump_scheduler_unittest.cc#newcode43 base/trace_event/memory_dump_scheduler_unittest.cc:43: return ...
2 months, 1 week ago (2017-03-21 06:48:01 UTC) #11
ssid
Thanks. comments inline. https://codereview.chromium.org/2743663005/diff/60001/base/trace_event/memory_dump_scheduler_unittest.cc File base/trace_event/memory_dump_scheduler_unittest.cc (right): https://codereview.chromium.org/2743663005/diff/60001/base/trace_event/memory_dump_scheduler_unittest.cc#newcode9 base/trace_event/memory_dump_scheduler_unittest.cc:9: #include "base/single_thread_task_runner.h" On 2017/03/21 06:48:00, dcheng ...
2 months, 1 week ago (2017-03-22 00:24:19 UTC) #12
dcheng
https://codereview.chromium.org/2743663005/diff/60001/base/trace_event/memory_dump_scheduler_unittest.cc File base/trace_event/memory_dump_scheduler_unittest.cc (right): https://codereview.chromium.org/2743663005/diff/60001/base/trace_event/memory_dump_scheduler_unittest.cc#newcode43 base/trace_event/memory_dump_scheduler_unittest.cc:43: return mds_->ShouldTriggerDump(total); On 2017/03/22 00:24:19, ssid wrote: > On ...
2 months, 1 week ago (2017-03-22 00:28:10 UTC) #15
ssid
https://codereview.chromium.org/2743663005/diff/60001/base/trace_event/memory_dump_scheduler_unittest.cc File base/trace_event/memory_dump_scheduler_unittest.cc (right): https://codereview.chromium.org/2743663005/diff/60001/base/trace_event/memory_dump_scheduler_unittest.cc#newcode9 base/trace_event/memory_dump_scheduler_unittest.cc:9: #include "base/single_thread_task_runner.h" On 2017/03/22 00:24:19, ssid wrote: > On ...
2 months, 1 week ago (2017-03-22 00:38:42 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743663005/120001
2 months, 1 week ago (2017-03-22 03:37:24 UTC) #27
commit-bot: I haz the power
Exceeded global retry quota
2 months, 1 week ago (2017-03-22 06:02:50 UTC) #30
Primiano Tucci
> Exceeded global retry quota Let's retry ticking commit again then. #AnarchyInTheUK
2 months, 1 week ago (2017-03-22 09:40:47 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743663005/120001
2 months, 1 week ago (2017-03-22 09:41:12 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/391394)
2 months, 1 week ago (2017-03-22 09:46:06 UTC) #35
krasin1
This CL broke CFI buildbots. Based on the fact that Rietveld shows a chromium_presubmit bot ...
2 months, 1 week ago (2017-03-22 15:59:59 UTC) #40
krasin1
> What was the reason to bypass the presubmit queue? The CL does not look ...
2 months, 1 week ago (2017-03-22 16:00:55 UTC) #41
Primiano Tucci
On 2017/03/22 15:59:59, krasin1 wrote: > This CL broke CFI buildbots. Based on the fact ...
2 months, 1 week ago (2017-03-22 16:02:59 UTC) #42
krasin1
Revert created: https://codereview.chromium.org/2766933004/
2 months, 1 week ago (2017-03-22 16:05:40 UTC) #43
ssid
On 2017/03/22 16:05:40, krasin1 wrote: > Revert created: https://codereview.chromium.org/2766933004/ I didn't force submit. But I ...
2 months, 1 week ago (2017-03-22 16:30:52 UTC) #44
ssid
On 2017/03/22 16:30:52, ssid wrote: > On 2017/03/22 16:05:40, krasin1 wrote: > > Revert created: ...
2 months, 1 week ago (2017-03-22 16:31:42 UTC) #45
ssid
2 months, 1 week ago (2017-03-22 17:35:59 UTC) #46
closing since it landed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06