Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2743563005: Reland of Added HardwareAccelerationEnabled() function (Closed)

Created:
3 years, 9 months ago by kinuko
Modified:
3 years, 9 months ago
Reviewers:
sugoi1, emaxx, jbauman, piman
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Added HardwareAccelerationEnabled() function (patchset #1 id:1 of https://codereview.chromium.org/2745733002/ ) Reason for revert: Ok, looks like this was the wrong one. Original issue's description: > Revert of Added HardwareAccelerationEnabled() function (patchset #1 id:1 of https://codereview.chromium.org/2737273003/ ) > > Reason for revert: > Speculative revert (will re-revert if false alarm) > > To see if reverting this fixes CloudPolicyManagerTest breakage > > Original issue's description: > > Added HardwareAccelerationEnabled() function > > > > Added a new utility function to clarify and simplify checking whether > > hardware acceleration is currently being used. > > > > R=emaxx@chromium.org, piman@chromium.org, jbauman@chromium.org > > BUG=630728 > > > > Review-Url: https://codereview.chromium.org/2737273003 > > Cr-Commit-Position: refs/heads/master@{#455947} > > Committed: https://chromium.googlesource.com/chromium/src/+/c0d9fe79fd4582f8170cef92d1e3ad211b5f8518 > > TBR=emaxx@chromium.org,jbauman@chromium.org,piman@chromium.org,sugoi@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=630728 > > Review-Url: https://codereview.chromium.org/2745733002 > Cr-Commit-Position: refs/heads/master@{#456006} > Committed: https://chromium.googlesource.com/chromium/src/+/7fc3177eec8f28989f48e1f45d4cdaec4566890a TBR=emaxx@chromium.org,jbauman@chromium.org,piman@chromium.org,sugoi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=630728 Review-Url: https://codereview.chromium.org/2743563005 Cr-Commit-Position: refs/heads/master@{#456015} Committed: https://chromium.googlesource.com/chromium/src/+/7e9da2599e7fe5c5dcea7439851066905ce6932b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M chrome/browser/policy/policy_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/public/browser/gpu_data_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
kinuko
Created Reland of Added HardwareAccelerationEnabled() function
3 years, 9 months ago (2017-03-10 07:15:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743563005/1
3 years, 9 months ago (2017-03-10 07:15:15 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 07:19:24 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7e9da2599e7fe5c5dcea74398510...

Powered by Google App Engine
This is Rietveld 408576698