Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2737273003: Added HardwareAccelerationEnabled() function (Closed)

Created:
3 years, 9 months ago by sugoi1
Modified:
3 years, 9 months ago
Reviewers:
emaxx, jbauman, piman
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added HardwareAccelerationEnabled() function Added a new utility function to clarify and simplify checking whether hardware acceleration is currently being used. R=emaxx@chromium.org, piman@chromium.org, jbauman@chromium.org BUG=630728 Review-Url: https://codereview.chromium.org/2737273003 Cr-Commit-Position: refs/heads/master@{#455947} Committed: https://chromium.googlesource.com/chromium/src/+/c0d9fe79fd4582f8170cef92d1e3ad211b5f8518

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M chrome/browser/policy/policy_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/gpu/gpu_data_manager_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M content/public/browser/gpu_data_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
sugoi1
Following up on a comment made in: https://codereview.chromium.org/2715563002/
3 years, 9 months ago (2017-03-09 19:18:14 UTC) #1
piman
lgtm
3 years, 9 months ago (2017-03-09 19:19:55 UTC) #2
jbauman
lgtm
3 years, 9 months ago (2017-03-09 22:03:49 UTC) #7
emaxx
LGTM. Thanks!
3 years, 9 months ago (2017-03-10 00:13:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2737273003/1
3 years, 9 months ago (2017-03-10 00:54:06 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c0d9fe79fd4582f8170cef92d1e3ad211b5f8518
3 years, 9 months ago (2017-03-10 01:27:00 UTC) #13
RE66
On 2017/03/10 01:27:00, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
3 years, 9 months ago (2017-03-10 04:01:49 UTC) #14
sugoi1
On 2017/03/10 04:01:49, RE66 wrote: > On 2017/03/10 01:27:00, commit-bot: I haz the power wrote: ...
3 years, 9 months ago (2017-03-10 04:19:02 UTC) #15
kinuko
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2745733002/ by kinuko@chromium.org. ...
3 years, 9 months ago (2017-03-10 05:59:54 UTC) #16
kinuko
3 years, 9 months ago (2017-03-10 07:15:49 UTC) #17
Message was sent while issue was closed.
On 2017/03/10 05:59:54, kinuko wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2745733002/ by
https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=kinuko@chromium.org.
> 
> The reason for reverting is: Speculative revert (will re-revert if false
alarm)
> 
> To see if reverting this fixes CloudPolicyManagerTest breakage.

Was a false alarm, reverting the revert!

Powered by Google App Engine
This is Rietveld 408576698