Move FrameHost::m_globalRootScrollerController to Page

Move FrameHost::m_globalRootScrollerController to Page

Move the field FrameHost::m_globalRootScrollerController to Page, and
update FrameHost methods to directly call the equivalent Page method.

BUG=691794
Review-Url: https://codereview.chromium.org/2743523002
Cr-Commit-Position: refs/heads/master@{#456605}
Committed: https://chromium.googlesource.com/chromium/src/+/5076fed2c0cfaaac4357e93d4fc890a82f1e34b5

[sashab, 2017-03-09 02:49:21]

sashab@chromium.org changed reviewers:
+ slangley@chromium.org

[sashab, 2017-03-09 02:49:30]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 02:49:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 03:02:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 03:02:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[slangley, 2017-03-09 04:18:28]

only nits

https://codereview.chromium.org/2743523002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/page/Page.h (right):

https://codereview.chromium.org/2743523002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/page/Page.h:51: class
TopDocumentRootScrollerController;
nit: sort

https://codereview.chromium.org/2743523002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/page/Page.h:193:
TopDocumentRootScrollerController& globalRootScrollerController() const;
why not inline?

[sashab, 2017-03-09 04:27:46]

Thanks stu; ptal.

https://codereview.chromium.org/2743523002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/page/Page.h (right):

https://codereview.chromium.org/2743523002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/page/Page.h:51: class
TopDocumentRootScrollerController;
On 2017/03/09 at 04:18:28, slangley wrote:
> nit: sort

Ty, weird how git cl format didn't do that.

https://codereview.chromium.org/2743523002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/page/Page.h:193:
TopDocumentRootScrollerController& globalRootScrollerController() const;
On 2017/03/09 at 04:18:28, slangley wrote:
> why not inline?

Prevent a #include? Copied from Page where it wasn't inline.

[sashab, 2017-03-09 04:27:50]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-09 04:28:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[slangley, 2017-03-09 04:29:18]

lgtm

[sashab, 2017-03-09 04:30:46]

sashab@chromium.org changed reviewers:
+ haraken@chromium.org

[sashab, 2017-03-09 04:30:47]

haraken ptal :)

[commit-bot: I haz the power, 2017-03-09 05:50:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 05:50:58]

Dry run: This issue passed the CQ dry run.

[haraken, 2017-03-09 06:27:54]

LGTM

[sashab, 2017-03-13 03:31:49]

The CQ bit was checked by sashab@chromium.org

[sashab, 2017-03-13 03:31:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
slangley@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2743523002/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-13 03:32:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-13 05:25:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-13 05:25:42]

Failed to apply patch for third_party/WebKit/Source/core/frame/FrameHost.cpp:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/Source/core/frame/FrameHost.cpp:52
  error: third_party/WebKit/Source/core/frame/FrameHost.cpp: patch does not
apply

Patch:       third_party/WebKit/Source/core/frame/FrameHost.cpp
Index: third_party/WebKit/Source/core/frame/FrameHost.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameHost.cpp
b/third_party/WebKit/Source/core/frame/FrameHost.cpp
index
e7ffb9b2a3e5b2da1bf7b3f0dbb239e8290e99fe..8cb85b9edb34a4ff8c31e658ffff4e7ebb748753
100644
--- a/third_party/WebKit/Source/core/frame/FrameHost.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameHost.cpp
@@ -35,7 +35,6 @@
 #include "core/inspector/ConsoleMessageStorage.h"
 #include "core/page/Page.h"
 #include "core/page/scrolling/OverscrollController.h"
-#include "core/page/scrolling/TopDocumentRootScrollerController.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebScheduler.h"
 
@@ -52,8 +51,6 @@ FrameHost::FrameHost(Page& page)
           OverscrollController::create(*m_visualViewport,
                                        m_page->chromeClient())),
       m_consoleMessageStorage(new ConsoleMessageStorage()),
-      m_globalRootScrollerController(
-          TopDocumentRootScrollerController::create(page)),
       m_subframeCount(0) {}
 
 // Explicitly in the .cpp to avoid default constructor in .h
@@ -101,7 +98,7 @@ const ConsoleMessageStorage&
FrameHost::consoleMessageStorage() const {
 
 TopDocumentRootScrollerController& FrameHost::globalRootScrollerController()
     const {
-  return *m_globalRootScrollerController;
+  return page().globalRootScrollerController();
 }
 
 DEFINE_TRACE(FrameHost) {
@@ -109,7 +106,6 @@ DEFINE_TRACE(FrameHost) {
   visitor->trace(m_visualViewport);
   visitor->trace(m_overscrollController);
   visitor->trace(m_consoleMessageStorage);
-  visitor->trace(m_globalRootScrollerController);
 }
 
 #if DCHECK_IS_ON()

[sashab, 2017-03-14 00:51:08]

The CQ bit was checked by sashab@chromium.org

[sashab, 2017-03-14 00:51:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
slangley@chromium.org, haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2743523002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-14 00:51:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 03:09:55]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1489452668554940,
"parent_rev": "b6004f10a03de0933f4c5d4241ac79dcd13c76c2", "commit_rev":
"5076fed2c0cfaaac4357e93d4fc890a82f1e34b5"}

[commit-bot: I haz the power, 2017-03-14 03:11:13]

Description was changed from

==========
Move FrameHost::m_globalRootScrollerController to Page

Move the field FrameHost::m_globalRootScrollerController to Page, and
update FrameHost methods to directly call the equivalent Page method.

BUG=691794
==========

to

==========
Move FrameHost::m_globalRootScrollerController to Page

Move the field FrameHost::m_globalRootScrollerController to Page, and
update FrameHost methods to directly call the equivalent Page method.

BUG=691794

Review-Url: https://codereview.chromium.org/2743523002
Cr-Commit-Position: refs/heads/master@{#456605}
Committed:
https://chromium.googlesource.com/chromium/src/+/5076fed2c0cfaaac4357e93d4fc8...
==========

[commit-bot: I haz the power, 2017-03-14 03:11:14]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/5076fed2c0cfaaac4357e93d4fc8...