Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Issue 2742673002: Remove FrameHost::globalRootScrollerController() (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 9 months ago
Reviewers:
haraken, joelhockey
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dglazkov+blink, dshwang, eae+blinkwatch, jchaffraix+rendering, kenneth.christiansen, kinuko+watch, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, sof, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove FrameHost::globalRootScrollerController() Remove FrameHost::globalRootScrollerController(), and redirect all calls to Page::globalRootScrollerController(). BUG=691794 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 #

Patch Set 2 : Rebase #

Messages

Total messages: 18 (11 generated)
sashab
3 years, 9 months ago (2017-03-09 03:10:51 UTC) #4
haraken
LGTM
3 years, 9 months ago (2017-03-09 06:29:42 UTC) #8
joelhockey
lgtm
3 years, 9 months ago (2017-03-10 00:27:24 UTC) #9
joelhockey
lgtm
3 years, 9 months ago (2017-03-10 00:27:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2742673002/20001
3 years, 9 months ago (2017-03-14 03:30:38 UTC) #13
commit-bot: I haz the power
Prior attempt to commit was detected, but we were not able to check whether the ...
3 years, 9 months ago (2017-03-14 06:02:52 UTC) #16
sashab
3 years, 9 months ago (2017-03-16 00:14:39 UTC) #18
Message was sent while issue was closed.
This landed... Not sure what that error is from :/

Powered by Google App Engine
This is Rietveld 408576698