Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2743423013: Re-enable shader disk cache on Adreno 4/5xx (Closed)

Created:
3 years, 9 months ago by ericrk
Modified:
3 years, 9 months ago
Reviewers:
vmiura
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable shader disk cache on Adreno 4/5xx Now that we have a mitigation for crashes in glProgramBinary when using cached shaders (crrev.com/2744363002), re-enabling the disk cache on the previous problematic devices. While we may still see crashes, these should be limited to 1 per client id, as opposed to the repeated crashes we see now. BUG=699122 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2743423013 Cr-Commit-Position: refs/heads/master@{#459488} Committed: https://chromium.googlesource.com/chromium/src/+/42267f803ddaadca1d2d716a478ea5f8dd9f169f

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -17 lines) Patch
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 chunks +1 line, -17 lines 0 comments Download

Messages

Total messages: 30 (22 generated)
ericrk
3 years, 9 months ago (2017-03-20 18:30:35 UTC) #7
vmiura
lgtm
3 years, 9 months ago (2017-03-20 20:13:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743423013/1
3 years, 9 months ago (2017-03-23 22:11:28 UTC) #18
commit-bot: I haz the power
Failed to apply patch for gpu/config/gpu_driver_bug_list_json.cc: While running git apply --index -p1; error: patch failed: ...
3 years, 9 months ago (2017-03-23 22:19:32 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743423013/20001
3 years, 9 months ago (2017-03-24 02:15:04 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/335151)
3 years, 9 months ago (2017-03-24 03:53:25 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743423013/20001
3 years, 9 months ago (2017-03-24 17:37:08 UTC) #27
commit-bot: I haz the power
3 years, 9 months ago (2017-03-24 18:40:42 UTC) #30
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/42267f803ddaadca1d2d716a478e...

Powered by Google App Engine
This is Rietveld 408576698