Re-enable shader disk cache on Adreno 4/5xx

Re-enable shader disk cache on Adreno 4/5xx

Now that we have a mitigation for crashes in glProgramBinary when using
cached shaders (crrev.com/2744363002), re-enabling the disk cache on
the previous problematic devices.

While we may still see crashes, these should be limited to 1 per client
id, as opposed to the repeated crashes we see now.

BUG=699122
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2743423013
Cr-Commit-Position: refs/heads/master@{#459488}
Committed: https://chromium.googlesource.com/chromium/src/+/42267f803ddaadca1d2d716a478ea5f8dd9f169f

[ericrk, 2017-03-17 21:27:27]

Description was changed from

==========
Re-enable shader disk cache on Adreno 4/5xx

Now that we have a mitigation for crashes in glProgramBinary when using
cached shaders (crrev.com/2744363002), re-enabling the disk cache on
the previous problematic devices.

While we may still see crashes, these should be limited to 1 per client
id, as opposed to the repeated crashes we see now.

BUG=699122
==========

to

==========
Re-enable shader disk cache on Adreno 4/5xx

Now that we have a mitigation for crashes in glProgramBinary when using
cached shaders (crrev.com/2744363002), re-enabling the disk cache on
the previous problematic devices.

While we may still see crashes, these should be limited to 1 per client
id, as opposed to the repeated crashes we see now.

BUG=699122
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ericrk, 2017-03-17 21:27:30]

The CQ bit was checked by ericrk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 21:28:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 23:16:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 23:16:31]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[ericrk, 2017-03-20 18:30:35]

ericrk@chromium.org changed reviewers:
+ vmiura@chromium.org

[ericrk, 2017-03-20 18:30:43]

The CQ bit was checked by ericrk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-20 18:31:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 19:19:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 19:19:30]

Dry run: Try jobs failed on following builders:
  android_optional_gpu_tests_rel on master.tryserver.chromium.android
(JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_opti...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vmiura, 2017-03-20 20:13:39]

lgtm

[vmiura, 2017-03-22 23:47:50]

The CQ bit was checked by vmiura@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 23:48:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 02:08:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 02:08:21]

Dry run: This issue passed the CQ dry run.

[ericrk, 2017-03-23 22:10:16]

The CQ bit was checked by ericrk@chromium.org

[commit-bot: I haz the power, 2017-03-23 22:11:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 22:19:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 22:19:32]

Failed to apply patch for gpu/config/gpu_driver_bug_list_json.cc:
While running git apply --index -p1;
  error: patch failed: gpu/config/gpu_driver_bug_list_json.cc:19
  error: gpu/config/gpu_driver_bug_list_json.cc: patch does not apply

Patch:       gpu/config/gpu_driver_bug_list_json.cc
Index: gpu/config/gpu_driver_bug_list_json.cc
diff --git a/gpu/config/gpu_driver_bug_list_json.cc
b/gpu/config/gpu_driver_bug_list_json.cc
index
df7fbf9a7b88107d154339ee25cdf681e0999b88..8664f87ba4249c5428b32c2b72a6939826df6c44
100644
--- a/gpu/config/gpu_driver_bug_list_json.cc
+++ b/gpu/config/gpu_driver_bug_list_json.cc
@@ -19,7 +19,7 @@ const char kGpuDriverBugListJson[] = LONG_STRING_CONST(
 {
   "name": "gpu driver bug list",
   // Please update the version number whenever you change this file.
-  "version": "9.36",
+  "version": "9.37",
   "entries": [
     {
       "id": 1,
@@ -2356,22 +2356,6 @@ LONG_STRING_CONST(
       ]
     },
     {
-      "id": 218,
-      "description": "Certain Adreno 4xx and 5xx drivers often crash in
glProgramBinary.",
-      "cr_bugs": [699122],
-      "os": {
-        "type": "android"
-      },
-      "driver_version": {
-        "op": ">=",
-        "value": "103.0"
-      },
-      "gl_renderer": "Adreno \\(TM\\) [45].*",
-      "features": [
-        "disable_program_disk_cache"
-      ]
-    },
-    {
       "id": 219,
       "description": "Zero-copy DXGI video hangs or displays incorrect colors
on AMD drivers",
       "cr_bugs": [623029],

[ericrk, 2017-03-24 02:14:45]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2017-03-24 02:14:45]

The patchset sent to the CQ was uploaded after l-g-t-m from vmiura@chromium.org
Link to the patchset: https://codereview.chromium.org/2743423013/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-24 02:15:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 03:53:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 03:53:25]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ericrk, 2017-03-24 17:36:25]

The CQ bit was checked by ericrk@chromium.org

[commit-bot: I haz the power, 2017-03-24 17:37:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 18:39:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490376985368380,
"parent_rev": "ec4834647c37a0b0b3a6b7cfa0a45f590eb9bd46", "commit_rev":
"42267f803ddaadca1d2d716a478ea5f8dd9f169f"}

[commit-bot: I haz the power, 2017-03-24 18:40:41]

Description was changed from

==========
Re-enable shader disk cache on Adreno 4/5xx

Now that we have a mitigation for crashes in glProgramBinary when using
cached shaders (crrev.com/2744363002), re-enabling the disk cache on
the previous problematic devices.

While we may still see crashes, these should be limited to 1 per client
id, as opposed to the repeated crashes we see now.

BUG=699122
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Re-enable shader disk cache on Adreno 4/5xx

Now that we have a mitigation for crashes in glProgramBinary when using
cached shaders (crrev.com/2744363002), re-enabling the disk cache on
the previous problematic devices.

While we may still see crashes, these should be limited to 1 per client
id, as opposed to the repeated crashes we see now.

BUG=699122
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2743423013
Cr-Commit-Position: refs/heads/master@{#459488}
Committed:
https://chromium.googlesource.com/chromium/src/+/42267f803ddaadca1d2d716a478e...
==========

[commit-bot: I haz the power, 2017-03-24 18:40:42]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/42267f803ddaadca1d2d716a478e...