Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 2743393002: Properly pin the incognito avatar. (Closed)

Created:
3 years, 9 months ago by Avi (use Gerrit)
Modified:
3 years, 9 months ago
Reviewers:
erikchen
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Properly pin the incognito avatar. BUG=700741 Review-Url: https://codereview.chromium.org/2743393002 Cr-Commit-Position: refs/heads/master@{#456419} Committed: https://chromium.googlesource.com/chromium/src/+/9e4313b0e961f192ac53ede509ab9426f5065efc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Avi (use Gerrit)
In https://codereview.chromium.org/2697293003 I saw that the autoresizing mask was done in both the AvatarButtonController and ...
3 years, 9 months ago (2017-03-13 16:12:39 UTC) #4
erikchen
lgtm
3 years, 9 months ago (2017-03-13 17:37:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743393002/1
3 years, 9 months ago (2017-03-13 17:39:17 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 17:45:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9e4313b0e961f192ac53ede509ab...

Powered by Google App Engine
This is Rietveld 408576698